Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix parameters permission conditional #7739

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ericholguin
Copy link
Contributor

This PR just simplifies the conditional used to check if roles and permissions are enabled.


Which Traffic Control components are affected by this PR?

  • Traffic Ops

What is the best way to verify this PR?

Run TO and make sure a user can view a secure parameter value with the right permissions

PR submission checklist

@ericholguin ericholguin added Traffic Ops related to Traffic Ops low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution labels Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #7739 (992a6fc) into master (75ec56f) will decrease coverage by 32.72%.
Report is 75 commits behind head on master.
The diff coverage is 25.06%.

@@              Coverage Diff              @@
##             master    #7739       +/-   ##
=============================================
- Coverage     65.05%   32.34%   -32.72%     
  Complexity       98       98               
=============================================
  Files           314      710      +396     
  Lines         12365    79773    +67408     
  Branches        907      965       +58     
=============================================
+ Hits           8044    25799    +17755     
- Misses         3968    51828    +47860     
- Partials        353     2146     +1793     
Flag Coverage Δ
golib_unit 52.63% <37.76%> (?)
grove_unit 12.02% <ø> (?)
t3c_unit 5.99% <3.31%> (?)
traffic_monitor_unit 26.33% <0.00%> (?)
traffic_ops_integration 69.39% <ø> (-0.03%) ⬇️
traffic_ops_unit 22.44% <4.38%> (?)
traffic_portal_v2 74.39% <74.17%> (+0.61%) ⬆️
traffic_stats_unit 10.76% <ø> (?)
unit_tests 29.60% <25.06%> (-44.18%) ⬇️
v3 57.79% <ø> (ø)
v4 79.18% <ø> (ø)
v5 78.52% <ø> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
cache-config/t3c-apply/config/config.go 0.00% <0.00%> (ø)
cache-config/t3c-apply/torequest/cmd.go 0.00% <0.00%> (ø)
cache-config/t3c-check-refs/t3c-check-refs.go 1.78% <0.00%> (ø)
cache-config/t3c-generate/cfgfile/varnish.go 0.00% <0.00%> (ø)
cache-config/t3c-generate/config/config.go 0.81% <0.00%> (-0.08%) ⬇️
cache-config/t3c-generate/t3c-generate.go 0.00% <ø> (ø)
experimental/traffic-portal/src/app/api/index.ts 100.00% <ø> (ø)
...mental/traffic-portal/src/app/api/testing/index.ts 100.00% <ø> (ø)
...perimental/traffic-portal/src/app/app.ui.module.ts 100.00% <ø> (ø)
...tatuses/statuses-table/statuses-table.component.ts 82.35% <ø> (ø)
... and 96 more

... and 353 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low impact affects only a small portion of a CDN, and cannot itself break one tech debt rework due to choosing easy/limited solution Traffic Ops related to Traffic Ops
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant