-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API testing services implement concrete services #7599
Open
ocket8888
wants to merge
28
commits into
apache:master
Choose a base branch
from
ocket8888:tpv2/api-testing-implementation
base: master
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
API testing services implement concrete services #7599
ocket8888
wants to merge
28
commits into
apache:master
from
ocket8888:tpv2/api-testing-implementation
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ocket8888
added
low impact
affects only a small portion of a CDN, and cannot itself break one
tests
related to tests and/or testing infrastructure
improvement
The functionality exists but it could be improved in some way.
experimental
a feature/component not directly supported by ATC
Traffic Portal v2
Related to the experimental Traffic Portal version 2
labels
Jun 26, 2023
Codecov Report
@@ Coverage Diff @@
## master #7599 +/- ##
=============================================
+ Coverage 31.83% 69.60% +37.76%
Complexity 98 98
=============================================
Files 717 324 -393
Lines 82720 12865 -69855
Branches 965 974 +9
=============================================
- Hits 26338 8955 -17383
+ Misses 54217 3574 -50643
+ Partials 2165 336 -1829
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 399 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
That was the only way I could implement the abstract class without extending it.
allowed creation of regions in non-existent divisions, wouldn't delete things by object as well as ID, etc. Also added 100% test coverage.
Also added 100% test coverage
Some were accepting IDs but not response structures. Also added 100% test coverage.
Used to only work on Ids. Also added 100% test coverage.
Also add 100% test coverage
Also fixed some bugs in the testing server service and added 100% test coverage.
also added 100% test coverage
Also add 100% test coverage
Part of this involved introducing a new utility type: ClassToInterface. Read the JSDoc comment to learn what it does.
ocket8888
force-pushed
the
tpv2/api-testing-implementation
branch
from
September 21, 2023 21:37
e00087c
to
1fed230
Compare
ocket8888
requested review from
shamrickus
and removed request for
shamrickus
September 22, 2023 02:17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
experimental
a feature/component not directly supported by ATC
improvement
The functionality exists but it could be improved in some way.
low impact
affects only a small portion of a CDN, and cannot itself break one
tests
related to tests and/or testing infrastructure
Traffic Portal v2
Related to the experimental Traffic Portal version 2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR is primarily meant to do is make keeping parity between API services and their mock testing services easier for developers. It does this by, for each API service, ensuring it is
implement
ed by the corresponding mock/testing service. For example, with the API service:in
experimental/traffic-portal/src/app/api
, this PR ensures there is a corresponding service inexperimental/traffic-portal/src/app/api/testing
such that:This means that adding functionality to the "concrete" service that isn't being properly mocked will result in testing compilation errors.
In order to ensure the services are working properly, this PR also adds 100% test coverage to
experimental/traffic-portal/src/app/api/testing
and fills any gaps in testing coverage forexperimental/traffic-portal/src/app/api
.Which Traffic Control components are affected by this PR?
What is the best way to verify this PR?
Make sure the provided tests pass.
PR submission checklist