Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIKA-3637] Adding sox audio tool to external parsers #282

Closed
wants to merge 2 commits into from
Closed

[TIKA-3637] Adding sox audio tool to external parsers #282

wants to merge 2 commits into from

Conversation

lsliwko
Copy link

@lsliwko lsliwko commented Sep 17, 2019

Sample output from sox --info duration-test-3.wav:

Input File : 'duration-test-3.wav'
Channels : 1
Sample Rate : 44100
Precision : 16-bit
Duration : 00:00:02.50 = 110298 samples = 187.582 CDDA sectors
File Size : 221k
Bit Rate : 706k
Sample Encoding: 16-bit Signed Integer PCM

Sample output from sox --info duration-test-3.wav:

Input File     : 'duration-test-3.wav'
Channels       : 1
Sample Rate    : 44100
Precision      : 16-bit
Duration       : 00:00:02.50 = 110298 samples = 187.582 CDDA sectors
File Size      : 221k
Bit Rate       : 706k
Sample Encoding: 16-bit Signed Integer PCM
@lsliwko
Copy link
Author

lsliwko commented Sep 17, 2019

Sox tool correctly pulls duration from wav files. I haven't seen any tests for external parsers anywhere.

@lewismc
Copy link
Member

lewismc commented Dec 30, 2021

Hi @lsliwko it looks like this PR is superseded by #451 correct?

@lsliwko
Copy link
Author

lsliwko commented Dec 30, 2021

#451 additionally adds parsing of wav file comments (as xmpDM:logComment). Both changes #282 and #451 go together.

@lewismc
Copy link
Member

lewismc commented Jan 3, 2022

Hi @lsliwko I'm confused as the pull request modifications in both #451 and this one look identical. Also no JIRA ticket exists for these proposals. Please create a JIRA ticket.
I have never used or developed the tika-external-parsers.xml file before but your pull request looks great as it is adding rather than attempting to change any existing source code.

Copy link
Member

@lewismc lewismc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lsliwko
Copy link
Author

lsliwko commented Jan 3, 2022

Here you go - JIRA ticket:
https://issues.apache.org/jira/browse/TIKA-3637

@lsliwko lsliwko changed the title Adding sox audio tool to external parsers [TIKA-3637] Adding sox audio tool to external parsers Jan 3, 2022
@lsliwko
Copy link
Author

lsliwko commented Jan 3, 2022

Sorry, you were right the code was duplicated in other pull request. I closed #451.

@lewismc
Copy link
Member

lewismc commented Jan 16, 2022

@lsliwko I just noticed that this PR is created against master branch. Please close it and create the PR aginst main branch. We will not merge it into master.

@lsliwko
Copy link
Author

lsliwko commented Jan 27, 2022

Closed as requested. New PR: #492

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants