py TSocket: Only disable socket.IPV6_V6ONLY when the family is AF_INET6 #2770
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes introduced in 916ae8b causes OSError when the socket is of IPv4 family. This can be verified by the code snippet below (at least on RHEL 8 and RHEL 9 with Python 3.9):
This will raise an exception
OSError: [Errno 92] Protocol not available
.My fix is pretty simple: only set that IPv6 option when the socket family is IPv6.