Migrate to the next version of Python requests when released #661
Comments
|
Thanks for letting us know. We're in the process of releasing Submarine 0.6.0. Any idea when the new requests will be out? |
|
Filed SUBMARINE-922 to track this issue. |
|
Tentatively 13 July psf/requests#5868 so rather soon :) |
|
Release just happened in fact https://pypi.org/project/requests/2.26.0/ |
asfgit
pushed a commit
that referenced
this issue
Aug 26, 2021
…leased ### What is this PR for? <!-- A few sentences describing the overall goals of the pull request's commits. First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html --> Install latest `request` in the pysubmarine. See Github issue: #661 Our python code uses requests library which has transitive dependency on a GPL lib chardet. We're not supposed to make an ASF release knowing there's a GPL transitive dependency so this is a blocker for our 0.6.0 release. Quickly checked the code, we have two places that use the library. We could wait for the new requests or perhaps remove the usage. ``` find . -name "*.py" | xargs grep "import requests" ./submarine-sdk/pysubmarine/submarine/utils/rest_utils.py:import requests ./submarine-sdk/pysubmarine/build/lib/submarine/utils/rest_utils.py:import requests ``` ### What type of PR is it? [Hot Fix] ### Todos No ### What is the Jira issue? <!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/ * Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title` --> https://issues.apache.org/jira/browse/SUBMARINE-922 ### How should this be tested? <!-- * First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration * Strongly recommended: add automated unit tests for any new or changed behavior * Outline any manual steps to test the PR here. --> Pass the CIs ### Screenshots (if appropriate) ### Questions: * Do the license files need updating? No * Are there breaking changes for older versions? No * Does this need new documentation? No Author: Kevin Su <pingsutw@apache.org> Signed-off-by: Kevin <pingsutw@apache.org> Closes #722 from pingsutw/SUBMARINE-922 and squashes the following commits: af04a0f [Kevin Su] Update setup.py
|
Close this issue due to a fix PR #722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hello Maintainers,
I am a PMC member of Apache Airflow, and I wanted to give you a bit of heads-up with rather important migration to the upcoming version of requests library in your Python release.
Since you are using requests library in your project, you are affected.
As discussed at length in https://issues.apache.org/jira/browse/LEGAL-572 we found out that the 'chardet
library used byrequests` library was a mandatory dependency to requests and since it has LGPL licence, we should not release any Apache Software with it.Since then (and since in Airflow we rely on requests heavily) we have been working with the requests maintainers and "charset-normalizer" maintainer to make it possible to replace chardet with MIT-licensed charset-normalizer instead so that requests library can be used in Python releases by Apache projects.
This was a bumpy road but finally the PR by @ashb has been merged: psf/requests#5797 and we hope soon a new version of requests library will be released.
This is just a heads-up. I will let you know when it is released, but I have a kind requests as well - I might ask the maintainers to release a release candidate of requests and maybe you could help to test it before it is released, that would be some re-assurance for the maintainers of requests who are very concerned about stability of their releases.
Let me know if you need any more information and whether you would like to help in testing the candidate when it is out.
The text was updated successfully, but these errors were encountered: