Skip to content

Commit

Permalink
SUBMARINE-922. Migrate to the next version of Python requests when re…
Browse files Browse the repository at this point in the history
…leased

### What is this PR for?
<!-- A few sentences describing the overall goals of the pull request's commits.
First time? Check out the contributing guide - https://submarine.apache.org/contribution/contributions.html
-->
Install latest `request` in the pysubmarine.

See Github issue: #661

Our python code uses requests library which has transitive dependency on a GPL lib chardet.

We're not supposed to make an ASF release knowing there's a GPL transitive dependency so this is a blocker for our 0.6.0 release.

Quickly checked the code, we have two places that use the library. We could wait for the new requests or perhaps remove the usage.

```
find . -name "*.py" | xargs grep "import requests"
./submarine-sdk/pysubmarine/submarine/utils/rest_utils.py:import requests
./submarine-sdk/pysubmarine/build/lib/submarine/utils/rest_utils.py:import requests
```

### What type of PR is it?
[Hot Fix]

### Todos
No

### What is the Jira issue?
<!-- * Open an issue on Jira https://issues.apache.org/jira/browse/SUBMARINE/
* Put link here, and add [SUBMARINE-*Jira number*] in PR title, eg. `SUBMARINE-23. PR title`
-->
https://issues.apache.org/jira/browse/SUBMARINE-922

### How should this be tested?
<!--
* First time? Setup Travis CI as described on https://submarine.apache.org/contribution/contributions.html#continuous-integration
* Strongly recommended: add automated unit tests for any new or changed behavior
* Outline any manual steps to test the PR here.
-->
Pass the CIs
### Screenshots (if appropriate)

### Questions:
* Do the license files need updating? No
* Are there breaking changes for older versions? No
* Does this need new documentation? No

Author: Kevin Su <pingsutw@apache.org>

Signed-off-by: Kevin <pingsutw@apache.org>

Closes #722 from pingsutw/SUBMARINE-922 and squashes the following commits:

af04a0f [Kevin Su] Update setup.py
  • Loading branch information
pingsutw committed Aug 26, 2021
1 parent f7d4c9e commit ea79029
Showing 1 changed file with 7 additions and 7 deletions.
14 changes: 7 additions & 7 deletions submarine-sdk/pysubmarine/setup.py
Expand Up @@ -33,18 +33,18 @@
'sqlalchemy',
'sqlparse',
'pymysql',
'requests',
'urllib3 >= 1.15.1',
'certifi >= 14.05.14',
'python-dateutil >= 2.5.3',
'requests==2.26.0',
'urllib3>=1.15.1',
'certifi>=14.05.14',
'python-dateutil>=2.5.3',
'pyarrow==0.17.0',
'mlflow>=1.15.0',
'boto3>=1.17.58',
],
extras_require={
'tf':['tensorflow>=1.14.0,<2.0.0'],
'tf-latest':['tensorflow'],
'pytorch':['torch>=1.5.0','torchvision>=0.6.0'],
'tf': ['tensorflow>=1.14.0,<2.0.0'],
'tf-latest': ['tensorflow'],
'pytorch': ['torch>=1.5.0', 'torchvision>=0.6.0'],
},
classifiers=[
'Intended Audience :: Developers',
Expand Down

0 comments on commit ea79029

Please sign in to comment.