[SPARK-48373][PYTHON] Allow schema parameter of createDataFrame() to be length-1 list or tuple of StructType #46687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianmcook
added a commit
to ianmcook/spark
that referenced
this pull request
May 21, 2024
ianmcook
added a commit
to ianmcook/spark
that referenced
this pull request
May 21, 2024
HyukjinKwon
reviewed
May 22, 2024
| assert_frame_equal(pdf_arrow, pdf) | ||
| for schema in [ | ||
| self.schema, | ||
| (self.schema,), |
There was a problem hiding this comment.
While I get the intention, let's probably don't do this. There are a lot of places like this, and I think it's not worthwhile fixing them all.
There was a problem hiding this comment.
Understood. Thanks for considering it.
ianmcook
added a commit
to ianmcook/spark
that referenced
this pull request
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Users will no longer get an error if they pass a length-1 list or tuple of StructType as the schema argument to createDataFrame()
Why are the changes needed?
In Python code it is easy to accidentally create a length-1 tuple of
StructTypeinstead of just aStructTypeif you leave a trailing comma at the end of a line.Does this PR introduce any user-facing change?
It prevents an unhelpful error message in this case.
How was this patch tested?
I modified one of the existing tests to test this.
Was this patch authored or co-authored using generative AI tooling?
No