Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-43348][PYTHON][TESTS][FOLLOW-UP] Skip the day-time-interval test only with PyPy 3.8 #41085

Closed
wants to merge 1 commit into from

Conversation

HyukjinKwon
Copy link
Member

What changes were proposed in this pull request?

This PR is a followup of #41024 that skips the test only with PyPy 3.8.

Why are the changes needed?

To narrow the scope of testing skipped.

Does this PR introduce any user-facing change?

No, test-only.

How was this patch tested?

CI in this PR should verify the change.

@HyukjinKwon HyukjinKwon changed the title [SPARK-43348][PYTHON][FOLLOW-UP] Skip the day-time-interval test only with PyPy 3.8 [SPARK-43348][PYTHON][TESTS][FOLLOW-UP] Skip the day-time-interval test only with PyPy 3.8 May 8, 2023
@HyukjinKwon
Copy link
Member Author

cc @dongjoon-hyun

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you.
Sorry for the late recovery.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented May 8, 2023

Could you re-trigger the failed linter tests? It looks irrelevant.

python/pyspark/broadcast.py:106: error: Overloaded function implementation does not accept all possible arguments of signature 3  [misc]
Found 1 error in 1 file (checked 511 source files)

@HyukjinKwon
Copy link
Member Author

^ That should be fixed by #41086.

@HyukjinKwon
Copy link
Member Author

But let me retrigger anyway .. seems another test got stuck ..

@HyukjinKwon
Copy link
Member Author

Merged to master.

@dongjoon-hyun
Copy link
Member

Thank you!

LuciferYang pushed a commit to LuciferYang/spark that referenced this pull request May 10, 2023
…st only with PyPy 3.8

### What changes were proposed in this pull request?

This PR is a followup of apache#41024 that skips the test only with PyPy 3.8.

### Why are the changes needed?

To narrow the scope of testing skipped.

### Does this PR introduce _any_ user-facing change?

No, test-only.

### How was this patch tested?

CI in this PR should verify the change.

Closes apache#41085 from HyukjinKwon/SPARK-43354-followup.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon HyukjinKwon deleted the SPARK-43354-followup branch January 15, 2024 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants