Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-41521][BUILD][K8S] Upgrade kubernetes-client to 6.3.0 #39065

Closed
wants to merge 1 commit into from

Conversation

panbingkun
Copy link
Contributor

@panbingkun panbingkun commented Dec 15, 2022

What changes were proposed in this pull request?

The PR aims to upgrade fabric8io - kubernetes-client from 6.2.0 to 6.3.0.

Why are the changes needed?

This version bring some bug fix, release notes as follow: Release notes

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass GA.

@github-actions github-actions bot added the BUILD label Dec 15, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for making a PR, @panbingkun .

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-41521][BUILD] Upgrade fabric8io - kubernetes-client from 6.2.0 to 6.3.0 [SPARK-41521][BUILD] Upgrade kubernetes-client to 6.3.0 Dec 15, 2022
@dongjoon-hyun
Copy link
Member

BTW, there exist breaking changes. Does this pass in your GitHub Action?

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. The dependency test failure is a known issue at master branch as of now.
Merged to master.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-41521][BUILD] Upgrade kubernetes-client to 6.3.0 [SPARK-41521][BUILD][K8S] Upgrade kubernetes-client to 6.3.0 Dec 15, 2022
@dongjoon-hyun
Copy link
Member

Also, cc @Yikun

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 15, 2022

Ur, @panbingkun . Although this passes K8s IT, this seems to have a regression with spark.kubernetes.submission.waitAppCompletion=false. Spark Submit seems to be not finished .
Could you double check by building and running with your K8s cluster, please?

@dongjoon-hyun
Copy link
Member

I'm also investigating to find the root cause.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 15, 2022

Unfortunately, I'm going to revert this because I verified that the regression is gone when I delete 6.3.0 jar files and put 6.2.0 jar files.

@dongjoon-hyun
Copy link
Member

beliefer pushed a commit to beliefer/spark that referenced this pull request Dec 18, 2022
### What changes were proposed in this pull request?
The PR aims to upgrade fabric8io - kubernetes-client from 6.2.0 to 6.3.0.

### Why are the changes needed?
This version bring some bug fix, release notes as follow: [Release notes](https://github.com/fabric8io/kubernetes-client/releases/tag/v6.3.0)

### Does this PR introduce _any_ user-facing change?
No.

### How was this patch tested?
Pass GA.

Closes apache#39065 from panbingkun/kubernetes_6.3.0.

Authored-by: panbingkun <pbk1982@gmail.com>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants