Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONT'MERGE] Unify the version of scala-maven-plugin used by hadoop-2 and hadoop-3 profile #38591

Closed

Conversation

LuciferYang
Copy link
Contributor

What changes were proposed in this pull request?

Why are the changes needed?

Does this PR introduce any user-facing change?

How was this patch tested?

@github-actions github-actions bot added the BUILD label Nov 10, 2022
@LuciferYang
Copy link
Contributor Author

Since SPARK-40651 dropped Hadoop2 binary distribution from release process, I think scala-maven-plugin used by hadoop-2 profile will no longer block execution of docker release script. So I hope to unify the version of scala-maven-plugin, I'm doing some tests, such as full compilation, make-distribution.sh, full testing and module testing.

I want to do this work because the change of Scala 2.13(since 2.13.9)and the -release options supported after scala-maven-plugin 4.7.2, but I'm not sure whether it's the right time, so I haven't filed Jira yet. I want to hear your suggestions @dongjoon-hyun .

@LuciferYang LuciferYang changed the title [DONT'MERGE] Unified scala maven plugin [DONT'MERGE] Unify the version of scala-maven-plugin used by hadoop-2 and hadoop-3 profile Nov 10, 2022
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, the Hadoop2 downstream users can use the release scripts still.

I think scala-maven-plugin used by hadoop-2 profile will no longer block execution of docker release script

@LuciferYang
Copy link
Contributor Author

Thanks @dongjoon-hyun let me close this one

@dongjoon-hyun
Copy link
Member

Thank you for closing, @LuciferYang .

@LuciferYang LuciferYang deleted the unified-scala-maven-plugin branch November 10, 2022 03:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants