Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-33843][BUILD] Upgrade to Zstd 1.4.8 #30848

Closed
wants to merge 2 commits into from
Closed

[SPARK-33843][BUILD] Upgrade to Zstd 1.4.8 #30848

wants to merge 2 commits into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Dec 19, 2020 •
edited

What changes were proposed in this pull request?

This PR aims to upgrade Zstd library to 1.4.8.

Why are the changes needed?

This will bring Zstd 1.4.7 and 1.4.8 improvement and bug fixes and the following from zstd-jni.

Does this PR introduce any user-facing change?

This will unblock Apple Silicon usage.

How was this patch tested?

Pass the CIs.

@github-actions github-actions bot added the BUILD label Dec 19, 2020
@dongjoon-hyun dongjoon-hyun marked this pull request as draft December 19, 2020 00:38
@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Test build #133041 has finished for PR 30848 at commit 179336c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@HyukjinKwon
Copy link
Member

retest this please

@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37653/

@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37653/

@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Test build #133053 has finished for PR 30848 at commit 179336c.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Dec 19, 2020

lgtm

@dongjoon-hyun
Copy link
Member Author

dongjoon-hyun commented Dec 19, 2020 •
edited

Wow. Thank you guys for the approval, @HyukjinKwon , @mridulm and @maropu .
I updated the PR to use 1.4.8-1 and remove Draft status.

@dongjoon-hyun dongjoon-hyun changed the title [SPARK-33843][BUILD] Upgrade to Zstd 1.4.7 [SPARK-33843][BUILD] Upgrade to Zstd 1.4.8 Dec 19, 2020
@dongjoon-hyun dongjoon-hyun marked this pull request as ready for review December 19, 2020 13:29
@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37666/

@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37666/

@dongjoon-hyun
Copy link
Member Author

Could you review and approve this once more? I switch SPARK-33843 from Improvement to Bug for Apache Spark 3.1.0, too.

srowen
srowen approved these changes Dec 19, 2020
View reviewed changes
Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine.

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen !

@dongjoon-hyun
Copy link
Member Author

Thank you, @maropu !

dongjoon-hyun added a commit that referenced this pull request Dec 19, 2020
@dongjoon-hyun
[SPARK-33843][BUILD] Upgrade to Zstd 1.4.8
ad2718d 
### What changes were proposed in this pull request?

This PR aims to upgrade Zstd library to 1.4.8.

### Why are the changes needed?

This will bring Zstd 1.4.7 and 1.4.8 improvement and bug fixes and the following from `zstd-jni`.
- https://github.com/facebook/zstd/releases/tag/v1.4.7
- https://github.com/facebook/zstd/releases/tag/v1.4.8
- luben/zstd-jni#153 (Apple M1 architecture)

### Does this PR introduce _any_ user-facing change?

This will unblock Apple Silicon usage.

### How was this patch tested?

Pass the CIs.

Closes #30848 from dongjoon-hyun/SPARK-33843.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
(cherry picked from commit 00642ee)
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun
Copy link
Member Author

Merged to master/3.1.

@dongjoon-hyun dongjoon-hyun deleted the SPARK-33843 branch December 19, 2020 15:00
@SparkQA
Copy link

SparkQA commented Dec 19, 2020

Test build #133066 has finished for PR 30848 at commit 3ca8a43.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maropu maropu maropu approved these changes

@srowen srowen srowen approved these changes

@mridulm mridulm mridulm approved these changes

@HyukjinKwon HyukjinKwon HyukjinKwon approved these changes

Assignees
No one assigned
Labels
BUILD
Projects
None yet
Milestone
No milestone
6 participants
@dongjoon-hyun @SparkQA @HyukjinKwon @maropu @srowen @mridulm