Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SPARK-33725][BUILD] Upgrade snappy-java to 1.1.8.2 #30690

Closed
wants to merge 1 commit into from
Closed

[SPARK-33725][BUILD] Upgrade snappy-java to 1.1.8.2 #30690

wants to merge 1 commit into from

Conversation

viirya
Copy link
Member

@viirya viirya commented Dec 9, 2020 •
edited

What changes were proposed in this pull request?

This upgrades snappy-java to 1.1.8.2.

Why are the changes needed?

Minor version upgrade that includes:

  • Fixed an initialization issue when using a recent Mac OS X version
  • Support Apple Silicon (M1, Mac-aarch64)
  • Fixed the pure-java Snappy fallback logic when no native library for your platform is found.

Does this PR introduce any user-facing change?

No

How was this patch tested?

Unit test.

@dongjoon-hyun
Copy link
Member

Yey! Thanks, @viirya .

dongjoon-hyun
dongjoon-hyun reviewed Dec 9, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, we already support ARM64, don't we? We have ARM64 Jenkins job for a long time.

Support Apple Silicon (M1, Mac-aarch64)

@viirya
Copy link
Member Author

viirya commented Dec 9, 2020

As this is minor upgrade and fixes a few bugs, seems okay to backport to branch-3.1 too. cc @dongjoon-hyun @HyukjinKwon

@viirya
Copy link
Member Author

viirya commented Dec 9, 2020

BTW, we already support ARM64, don't we? We have ARM64 Jenkins job for a long time.

Support Apple Silicon (M1, Mac-aarch64)

I guess so. But I am not sure if there is any difference between Apple Silicon and ARM64.

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Dec 9, 2020 •
edited

@viirya . For the bug fixes, we may need to land this to all live branches (master/branch-3.1/branch-3.2/branch-2.4) if that is true.

Fixed an initialization issue when using a recent Mac OS X version

Please see the symptom of the new Mac on the PR description.

@github-actions github-actions bot added the BUILD label Dec 9, 2020
@viirya
Copy link
Member Author

viirya commented Dec 9, 2020

BTW, we already support ARM64, don't we? We have ARM64 Jenkins job for a long time.

Support Apple Silicon (M1, Mac-aarch64)

I guess so. But I am not sure if there is any difference between Apple Silicon and ARM64.

As I checked snappy-java's Makefile, the original ARM64 support is only for Linux-aarch64 before.

@dongjoon-hyun
Copy link
Member

Thanks. I converted SPARK-33725 from Improvement to Bug and set the affected versions 2.4.7, 3.0.1, 3.1.0, 3.2.0 .

@viirya
Copy link
Member Author

viirya commented Dec 9, 2020

Thanks @dongjoon-hyun !

@SparkQA
Copy link

SparkQA commented Dec 9, 2020

Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37113/

@SparkQA
Copy link

SparkQA commented Dec 9, 2020

Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37113/

dongjoon-hyun
dongjoon-hyun approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Merged to master.

@dongjoon-hyun
Copy link
Member

There is a conflict at branch-3.1. Could you make a backporting PR to old release branches?

@viirya
Copy link
Member Author

viirya commented Dec 9, 2020

Yea, thanks @dongjoon-hyun.

@SparkQA
Copy link

SparkQA commented Dec 9, 2020

Test build #132512 has finished for PR 30690 at commit b4a8305.

  • This patch fails Spark unit tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@maropu
Copy link
Member

maropu commented Dec 9, 2020

lgtm

wangyum pushed a commit that referenced this pull request May 26, 2023
@turboFei
[CARMEL-6489][SPARK-33205][SPARK-33725][SPARK=35277][BUILD] Bump snap…
2d2f2b0 
…py-java version to 1.1.8.4 (#1198)

* [CARMEL-6489][SPARK-33205][BUILD] Bump snappy-java version to 1.1.8
Backport #30120

* [CARMEL-6489][SPARK-33725][BUILD] Upgrade snappy-java to 1.1.8.2
Backport #30690

* [CARMEL-6489][SPARK-35277][BUILD] Upgrade snappy to 1.1.8.4
Backport #32402
@viirya viirya deleted the upgrade-snappy branch December 27, 2023 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dongjoon-hyun dongjoon-hyun dongjoon-hyun approved these changes

Assignees
No one assigned
Labels
BUILD
Projects
None yet
Milestone
No milestone
4 participants
@viirya @dongjoon-hyun @SparkQA @maropu