Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final #27870

Closed
wants to merge 1 commit into from
Closed

[SPARK-31095][BUILD][2.4] Upgrade netty-all to 4.1.47.Final #27870

wants to merge 1 commit into from

Conversation

dongjoon-hyun
Copy link
Member

@dongjoon-hyun dongjoon-hyun commented Mar 11, 2020

What changes were proposed in this pull request?

This is a backport of #27869.

This PR aims to bring the bug fixes from the latest netty-all.

Why are the changes needed?

Does this PR introduce any user-facing change?

No.

How was this patch tested?

Pass the Jenkins with the existing tests.

@yhuai
Copy link
Contributor

yhuai commented Mar 11, 2020

What is the bug you want to patch? I think it is risky to pull in those changes in without explaining any specific reason.

@dongjoon-hyun
Copy link
Member Author

CVE-2019-20445 is reported at https://issues.apache.org/jira/browse/SPARK-31095 by the author.

@dongjoon-hyun
Copy link
Member Author

Also, in Netty-all 4.1.39 - 4.1.45, there are other fixes like

@SparkQA
Copy link

SparkQA commented Mar 11, 2020

Test build #119640 has finished for PR 27870 at commit 50b377d.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@dongjoon-hyun
Copy link
Member Author

Ping, @yhuai . Do you have still have a concern on this PR?

@dongjoon-hyun
Copy link
Member Author

Hi, @srowen . Could you review this PR?

Copy link
Member

@srowen srowen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure seems fine as a back port for the reasons on the other PR

@dongjoon-hyun
Copy link
Member Author

Thank you, @srowen ! Merged to branch-2.4.

dongjoon-hyun added a commit that referenced this pull request Mar 11, 2020
### What changes were proposed in this pull request?

This is a backport of #27869.

This PR aims to bring the bug fixes from the latest netty-all.

### Why are the changes needed?

- 4.1.47.Final: https://github.com/netty/netty/milestone/222?closed=1 (15 patches or issues)
- 4.1.46.Final: https://github.com/netty/netty/milestone/221?closed=1 (80 patches or issues)
- 4.1.45.Final: https://github.com/netty/netty/milestone/220?closed=1 (23 patches or issues)
- 4.1.44.Final: https://github.com/netty/netty/milestone/218?closed=1 (113 patches or issues)
- 4.1.43.Final: https://github.com/netty/netty/milestone/217?closed=1 (63 patches or issues)

### Does this PR introduce any user-facing change?

No.

### How was this patch tested?

Pass the Jenkins with the existing tests.

Closes #27870 from dongjoon-hyun/netty.

Authored-by: Dongjoon Hyun <dongjoon@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
@dongjoon-hyun dongjoon-hyun deleted the netty branch March 11, 2020 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
4 participants