Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPARK-30486][BUILD] Bump lz4-java version to 1.7.1 #27271

Closed
wants to merge 1 commit into from

Conversation

maropu
Copy link
Member

@maropu maropu commented Jan 18, 2020

What changes were proposed in this pull request?

This pr intends to upgrade lz4-java from 1.7.0 to 1.7.1.

Why are the changes needed?

This release includes a bug fix for older macOS. You can see the link below for the changes;
https://github.com/lz4/lz4-java/blob/master/CHANGES.md#171

Does this PR introduce any user-facing change?

How was this patch tested?

Existing tests.

@maropu
Copy link
Member Author

maropu commented Jan 18, 2020

cc: @HyukjinKwon @dongjoon-hyun @srowen

@maropu
Copy link
Member Author

maropu commented Jan 18, 2020

FYI: lz4/lz4-java#156

@dongjoon-hyun
Copy link
Member

dongjoon-hyun commented Jan 18, 2020

Yes, I've been waiting for this, @maropu .
However, it seems that we need to wait for one or two days because Google Maven Central is not mirroring it yet.

[ERROR] Failed to execute goal on project spark-core_2.12: 
Could not resolve dependencies for project org.apache.spark:spark-core_2.12:jar:3.0.0-SNAPSHOT:
Could not find artifact org.lz4:lz4-java:jar:1.7.1 in google-maven-central (
https://maven-central.storage-download.googleapis.com/repos/central/data/) -> [Help 1]

@dongjoon-hyun
Copy link
Member

The Jenkins will pass because Google Maven Central is only used in GitHub Action.
So, we can merge this when GitHub Action passes.

@kiszk
Copy link
Member

kiszk commented Jan 18, 2020

This is not available yet at https://mvnrepository.com/artifact/org.lz4/lz4-java/1.7.1, too.

@SparkQA
Copy link

SparkQA commented Jan 18, 2020

Test build #116972 has finished for PR 27271 at commit bdf7bfc.

  • This patch fails due to an unknown error code, -9.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Jan 19, 2020

retest this please

@SparkQA
Copy link

SparkQA commented Jan 19, 2020

Test build #116982 has finished for PR 27271 at commit bdf7bfc.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

@kiszk
Copy link
Member

kiszk commented Jan 19, 2020

@dongjoon-hyun
Copy link
Member

Hi, @maropu and @kiszk . I found a solution for this. Could you review this?

@maropu
Copy link
Member Author

maropu commented Jan 20, 2020

Rebased to master.

@dongjoon-hyun
Copy link
Member

Thank you, @maropu !

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. (Pending GitHub Action)

@dongjoon-hyun
Copy link
Member

Thank you, @maropu, @kiszk , and @HyukjinKwon .
This PR already passed Jenkins and now GitHub Action also passed.
Merged to master.

@maropu
Copy link
Member Author

maropu commented Jan 20, 2020

Thanks, @dongjoon-hyun !

@SparkQA
Copy link

SparkQA commented Jan 20, 2020

Test build #117051 has finished for PR 27271 at commit 3eade4b.

  • This patch passes all tests.
  • This patch merges cleanly.
  • This patch adds no public classes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
5 participants