Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SOLR-17307: Use file separator instead of '/' in CachingDirectoryFactory #2464

Merged
merged 3 commits into from
May 23, 2024
Merged

SOLR-17307: Use file separator instead of '/' in CachingDirectoryFactory #2464

merged 3 commits into from
May 23, 2024

Conversation

HoustonPutman
Copy link
Contributor

@HoustonPutman HoustonPutman commented May 16, 2024 •
edited

@github-actions github-actions bot added the tests label May 16, 2024
magibney
magibney approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@magibney magibney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing.

I'm not able to test on Windows, but this fix would definitely stand to reason.

@epugh
Copy link
Contributor

epugh commented May 22, 2024

@HoustonPutman would you like me to merge this one?

@HoustonPutman
Copy link
Contributor Author

I need to make a separate JIRA so we can target 9.6.1 with it. I'll do it though, thanks for the offer 🙂

@HoustonPutman HoustonPutman changed the title SOLR-16866: Use file separator instead of '/' in CachingDirectoryFactory SOLR-17307: Use file separator instead of '/' in CachingDirectoryFactory May 22, 2024
@HoustonPutman HoustonPutman merged commit 917e682 into apache:main May 23, 2024
2 of 3 checks passed
@HoustonPutman HoustonPutman deleted the caching-directory-windows branch May 23, 2024 00:05
HoustonPutman added a commit that referenced this pull request May 23, 2024
@HoustonPutman
SOLR-17307: Use file separator instead of '/' in CachingDirectoryFact…
a8bd28c 
…ory (#2464)

(cherry picked from commit 917e682)
HoustonPutman added a commit that referenced this pull request May 23, 2024
@HoustonPutman
SOLR-17307: Use file separator instead of '/' in CachingDirectoryFact…
91e761e 
…ory (#2464)

(cherry picked from commit 917e682)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magibney magibney magibney approved these changes

@hossman hossman Awaiting requested review from hossman

Assignees
No one assigned
Labels
tests
Projects
None yet
Milestone
No milestone
3 participants
@HoustonPutman @epugh @magibney