Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-17274: allow JSON atomic updates to use multiple modifiers or a modifier like 'set' as a field name if child docs not enabled #2451

Merged
merged 9 commits into from
May 11, 2024

Commits on May 8, 2024

  1. fix two problems with json atomic update [SOLR-17274]

     - this modifies `isChildDoc` to always return false if child docs are
       not possible according to the schema, and restores part of the
       logic of `parseObjectFieldValue` so that it can handle
       multiple modifiers
     - re-enables the ability to use multiple modifiers in a single
       update, like `{"add": "foo", "remove": "bar"}`
     - re-enables the ability to have a field with a name like
       `set` or `remove` and be able to use updates like
       `{"set": {"set": "foo"}`
     - both of these are possible now but only if the schema
       doesn't support child/nested docs; if the schema does
       support them, then functionality is unchanged and either
       will continue throwing an exception
    Calvin Smith committed May 8, 2024
    Configuration menu
    Copy the full SHA
    9262c65 View commit details
    Browse the repository at this point in the history

Commits on May 10, 2024

  1. use assertFalse and use singular for test file name

    Calvin Smith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    38fec30 View commit details
    Browse the repository at this point in the history
  2. remove 'indent=true', and all but one uses of HashMap

     - Map.of doesn't allow null values, so there's still one
       remaining use of HashMap
    Calvin Smith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    4887252 View commit details
    Browse the repository at this point in the history
  3. not needed since there are no nested docs in these tests

    Calvin Smith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    25053aa View commit details
    Browse the repository at this point in the history
  4. use delQ instead of copied raw query

    Calvin Smith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b083a77 View commit details
    Browse the repository at this point in the history
  5. no instance initializer (to avoid precommit error)

    Calvin Smith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    111641e View commit details
    Browse the repository at this point in the history
  6. comment-only update

    Calvin Smith committed May 10, 2024
    Configuration menu
    Copy the full SHA
    b471e18 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7897402 View commit details
    Browse the repository at this point in the history
  8. CHANGES.txt

    dsmiley committed May 10, 2024
    Configuration menu
    Copy the full SHA
    1f4b4a0 View commit details
    Browse the repository at this point in the history