Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SOLR-16562 / SOLR-16578: Upgrade caffeine to 3.1.4 and errorprone to 2.18.0 #1380

Merged

Conversation

solrbot
Copy link
Collaborator

@solrbot solrbot commented Feb 24, 2023

This PR contains the following updates:

Package Type Update Change Pending
com.github.ben-manes.caffeine:caffeine dependencies patch 3.1.2 -> 3.1.3 3.1.4

Release Notes

ben-manes/caffeine

v3.1.3: 3.1.3

Cache

  • Fixed the build time dependency constraints from being leaked into the external metadata (#​867)
  • Fixed the cause of a removal notification for a discarded refresh when the entry was removed
  • Fixed the behavior for null lookups into returned unmodifiable maps to be consistent (#​864)
  • Fixed an unexpected delay of removal notifications when using a scheduler (#​859)
  • Fixed explicit refreshes from being deduped if the entry is pending eviction
  • Defaulted methods to @​CheckReturnValue for static analysis (#​863)
  • Reduced the lock hold time during Map.clear (#​835)

JCache

  • Fixed putAll with an immutable map that causes an exception when using a cache writer (#​841)

Configuration

📅 Schedule: Branch creation - "* 8-20 * * *" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot

@solrbot solrbot force-pushed the renovate/com.github.ben-manes.caffeine-caffeine-3.x branch from 86ed447 to 37c9f7c Compare February 24, 2023 13:14
Copy link
Contributor

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one needs a closer look. This ends up being a relatively bigger change due to changes to how caffeine fixed their transitive dependencies. https://issues.apache.org/jira/browse/SOLR-16562 has some details and #1198 (comment)

@risdenk
Copy link
Contributor

risdenk commented Feb 24, 2023

I wonder why this didn't go directly to 3.1.4? - https://github.com/ben-manes/caffeine/releases/tag/v3.1.4

@janhoy
Copy link
Contributor

janhoy commented Feb 24, 2023

3.1.4 was released 4 days and we use a 5 day delay, so it will likely be updated tomorrow. You see it in the “pending” column of the table above.

Copy link
Contributor

@risdenk risdenk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the changed dependencies. The only one that we currently manage in versions.props is errorprone and so need to update versions.props with com.google.errorprone:*=2.18.

@chatman
Copy link
Contributor

chatman commented Feb 24, 2023

@janhoy Can we add a [renovatebot] to the PR title, please? I think dependabot used to do that.

Edit: oops, dependabot didn't do that.

@solrbot
Copy link
Collaborator Author

solrbot commented Feb 24, 2023

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

Warning: custom changes will be lost.

@janhoy
Copy link
Contributor

janhoy commented Feb 24, 2023

We can customize title, but I’d instead like to add label “dependencies” on all these. Requires Solr bot to have “triage” karma, but that’s easily done in asf.yaml

@janhoy
Copy link
Contributor

janhoy commented Feb 26, 2023

X-ref #1400 - which will be auto closed once this is merged.

@janhoy janhoy changed the title Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.3 Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.4 Feb 26, 2023
@janhoy janhoy changed the title Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.4 SOLR-16562 Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.4 Feb 26, 2023
@janhoy
Copy link
Contributor

janhoy commented Feb 26, 2023

Found existing JIRA https://issues.apache.org/jira/browse/SOLR-16562 for 9.2, so I tagged title and bumped CHANGES

@risdenk risdenk changed the title SOLR-16562 Update dependency com.github.ben-manes.caffeine:caffeine to v3.1.4 SOLR-16562 / SOLR-16578: Upgrade caffeine to v3.1.4 and errorprone to 2.18.0 Feb 27, 2023
@risdenk risdenk changed the title SOLR-16562 / SOLR-16578: Upgrade caffeine to v3.1.4 and errorprone to 2.18.0 SOLR-16562 / SOLR-16578: Upgrade caffeine to 3.1.4 and errorprone to 2.18.0 Feb 27, 2023
@risdenk
Copy link
Contributor

risdenk commented Feb 27, 2023

Added changes to SOLR-16578 for errorprone since might as well fix that entry too.

@risdenk risdenk merged commit 4d50e27 into apache:main Feb 27, 2023
risdenk added a commit that referenced this pull request Feb 27, 2023
…2.18.0 (#1380)

Co-authored-by: Kevin Risden <krisden@apache.org>
Co-authored-by: Jan Høydahl <janhoy@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants