Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update frontend-maven-plugin to 1.11.0, for Download node x64 binary on Apple Silicon. #6282

Merged
merged 7 commits into from Feb 2, 2021
Merged

Update frontend-maven-plugin to 1.11.0, for Download node x64 binary on Apple Silicon. #6282

merged 7 commits into from Feb 2, 2021

Conversation

zifeihan
Copy link
Member

Update frontend-maven-plugin to 1.11.0, for Download node x64 binary on Apple Silicon.

  • If this is non-trivial feature, paste the links/URLs to the design doc.
  • Update the documentation to include this new feature.
  • Tests(including UT, IT, E2E) are added to verify the new feature.
  • If it's UI related, attach the screenshots below.
  • If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #.
  • Update the CHANGES log.

Update frontend-maven-plugin to 1.11.0, for Download node x64 binary on Apple Silicon, link: eirslett/frontend-maven-plugin#949 , and It has been updated to version 1.11.0 and released to the maven repository.

@codecov
Copy link

codecov bot commented Jan 30, 2021

Codecov Report

Merging #6282 (faaf4db) into master (cdfe6ab) will increase coverage by 1.34%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #6282      +/-   ##
============================================
+ Coverage     51.44%   52.79%   +1.34%     
- Complexity     3643     3790     +147     
============================================
  Files          1731     1731              
  Lines         36929    36899      -30     
  Branches       4065     4076      +11     
============================================
+ Hits          18998    19479     +481     
+ Misses        16955    16446     -509     
+ Partials        976      974       -2     
Impacted Files Coverage Δ Complexity Δ
.../log/provider/handler/LogReportServiceHandler.java 67.56% <0.00%> (-2.71%) 3.00% <0.00%> (ø%)
...erver/library/util/MultipleFilesChangeMonitor.java 69.04% <0.00%> (-0.47%) 13.00% <0.00%> (+13.00%) ⬇️
...ywalking/apm/agent/core/jvm/gc/SerialGCModule.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...alking/apm/agent/core/context/ContextSnapshot.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...lking/apm/agent/core/util/CustomizeExpression.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...king/apm/agent/core/context/ExtensionInjector.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...ent/core/jvm/memorypool/SerialCollectorModule.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)
...skywalking/oap/server/core/analysis/IDManager.java 62.96% <0.00%> (+0.69%) 2.00% <0.00%> (ø%)
.../provider/trace/parser/listener/SourceBuilder.java 93.70% <0.00%> (+0.78%) 12.00% <0.00%> (+1.00%)
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cdfe6ab...63d256f. Read the comment docs.

@kezhenxu94 kezhenxu94 added chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. dependencies Pull requests that update a dependency file labels Jan 30, 2021
@wu-sheng wu-sheng added this to the 8.5.0 milestone Jan 30, 2021
@wu-sheng
Copy link
Member

This will be considered after 8.4.0 code freeze.

@wu-sheng
Copy link
Member

wu-sheng commented Feb 2, 2021

Please update the changelog of project section.

@wu-sheng wu-sheng merged commit 59114fe into apache:master Feb 2, 2021
@zifeihan zifeihan deleted the frontend_compile branch February 2, 2021 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Chores about the project, like code cleaning up, typos, upgrading dependencies, etc. dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants