Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix http trace not sent if connection is keep-alive #121

Merged
merged 2 commits into from
Nov 29, 2023

Conversation

liu-zhizhu
Copy link
Contributor

@liu-zhizhu liu-zhizhu commented Nov 23, 2023

changing wrapEmit(span, res, false) to wrapEmit(span, res, false, 'end')
@tkNobug
Copy link

tkNobug commented Nov 23, 2023 via email

@kezhenxu94 kezhenxu94 changed the title Update HttpPlugin.ts for fix (https://github.com/apache/skywalking/issues/11583) Fix http trace not sent if connection is keep-alive Nov 23, 2023
@kezhenxu94
Copy link
Member

@aunsy-com the tests failed, can you take a look?

@liu-zhizhu
Copy link
Contributor Author

@aunsy-com the tests failed, can you take a look?

from the error log, it looks like the env start error, then the test case execute failed
image

@wu-sheng
Copy link
Member

We seem not to set up required CI and sync with latest target branch

@kezhenxu94
Copy link
Member

@aunsy-com thank you!

@kezhenxu94 kezhenxu94 merged commit 530e372 into apache:master Nov 29, 2023
45 checks passed
@wu-sheng wu-sheng modified the milestones: 0.7.0, 0.8.0 Nov 29, 2023
@liu-zhizhu
Copy link
Contributor Author

@aunsy-com thank you!

It's my pleasure, and thank you for your team work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants