Bump up test tool and testcontainers to fix tests (#122)

apache · Nov 29, 2023 · d0b4ed1 · d0b4ed1
1 parent 4f9a91d
commit d0b4ed1
Show file tree

Hide file tree

Showing 7 changed files with 495 additions and 95 deletions.
diff --git a/.github/workflows/test.yaml b/.github/workflows/test.yaml
@@ -24,12 +24,49 @@ on:
       - master
 
 jobs:
+  lint:
+    name: Lint
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+      - uses: actions/cache@v2
+        with:
+          path: ~/.npm
+          key: ${{ runner.os }}-node-${{ hashFiles('**/package-lock.json') }}
+          restore-keys: |
+            ${{ runner.os }}-node-
+      - name: Set Up NodeJS ${{ matrix.node-version }}
+        uses: actions/setup-node@v2-beta
+        with:
+          node-version: 14
+      - name: Lint
+        run: |
+          npm i
+          npm run lint
+
+  build-matrix:
+    runs-on: ubuntu-latest
+    timeout-minutes: 5
+    outputs:
+      plugins: ${{ steps.plugins.outputs.plugins }}
+    steps:
+      - uses: actions/checkout@v2
+        with:
+          submodules: true
+      - id: plugins
+        run: echo "plugins=$(ls tests/plugins | grep -v common | jq --raw-input | jq --slurp --compact-output)" >> "$GITHUB_OUTPUT"
+
   TestPlugins:
     runs-on: ubuntu-latest
     timeout-minutes: 30
+    needs: [ build-matrix ]
     strategy:
       matrix:
-        node-version: [ 10, 12, 14, 16, 18 ]
+        node-version: [ 14, 16, 18, 20 ]
+        plugin: ${{ fromJson(needs.build-matrix.outputs.plugins) }}
     env:
       SW_NODE_VERSION: ${{ matrix.node-version }}
     steps:
@@ -49,18 +86,10 @@ jobs:
         with:
           node-version: ${{ matrix.node-version }}
 
-      - name: Test On Node@12 And Above(Current:Node@${{matrix.node-version}})
-        if: matrix.node-version >= 12
-        run: |
-          npm i
-          npm run lint
-          npm run test
-
-      - name: Test On Node@10
-        if: matrix.node-version == 10
+      - name: Test On Node@${{ matrix.node-version }}
         run: |
           npm i
-          npm run test
+          npm run test tests/plugins/${{ matrix.plugin }}/
 
   TestLib:
     runs-on: ubuntu-latest

diff --git a/README.md b/README.md
@@ -22,7 +22,9 @@ $ npm install --save skywalking-backend-js
 
 ## Set up NodeJS Agent
 
-SkyWalking NodeJS SDK requires SkyWalking backend (OAP) 8.0+ and NodeJS >= 10.
+SkyWalking NodeJS SDK requires SkyWalking backend (OAP) 8.0+ and NodeJS >= 14,
+other versions are not tested and SkyWalking NodeJS SDK may or may not work,
+please make sure to use the supported versions before reporting any issue.
 
 ```typescript
 import agent from 'skywalking-backend-js';