Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Ability to set a property value with an enum in shiro.ini file #25

Closed
wants to merge 1 commit into from

Conversation

bdemers
Copy link
Member

@bdemers bdemers commented Jul 6, 2016

SHIRO-425 (applied patch to master)
This enum support could be limited to property only, but that might cause confusion.

Currently supported via this patch:

[main]
myObject = com.foo.bar.Type
myObject.enumProperty = ENUM_VALUE1

This is really cool, but as a user I would also expect the following to work:

[main]
myObject = com.foo.bar.Type
myObject.enumListProperty = ENUM_VALUE1, ENUM_VALUE2
[main]
myObject = com.foo.bar.Type
myObject.enumMapProperty = one:ENUM_VALUE1, two:ENUM_VALUE2

Granted the Map example might be a bit contrived, but less so for the list.

I've added a test for this.

Thoughts ?

@bdemers
Copy link
Member Author

bdemers commented Jul 6, 2016

cc: @leleuj

@leleuj
Copy link
Contributor

leleuj commented Jul 11, 2016

This looks good to me

@fpapon
Copy link
Member

fpapon commented Mar 29, 2020

supercedes by #199
We can close this one

@fpapon fpapon closed this Mar 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants