Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build GraalVM Native Image nightly for ShardingSphere Proxy #21109

Merged
merged 4 commits into from
Oct 3, 2022

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Sep 21, 2022

For #21051.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have triggered maven check: mvn clean install -B -T2C -DskipTests -Dmaven.javadoc.skip=true -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@codecov-commenter
Copy link

codecov-commenter commented Sep 21, 2022

Codecov Report

Merging #21109 (b1e04b0) into master (e5cf12d) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master   #21109      +/-   ##
============================================
- Coverage     61.61%   61.61%   -0.01%     
+ Complexity     2479     2475       -4     
============================================
  Files          4061     4064       +3     
  Lines         55882    55867      -15     
  Branches       9466     9464       -2     
============================================
- Hits          34430    34420      -10     
+ Misses        18575    18571       -4     
+ Partials       2877     2876       -1     
Impacted Files Coverage Δ
...saction/xa/XAShardingSphereTransactionManager.java 65.00% <0.00%> (-2.50%) ⬇️
...ardingsphere/transaction/rule/TransactionRule.java 33.33% <0.00%> (-0.63%) ⬇️
...eterized/jaxb/cases/domain/SQLParserTestCases.java 99.30% <0.00%> (-0.01%) ⬇️
...ser/core/kernel/KernelDistSQLStatementVisitor.java 0.00% <0.00%> (ø)
...eption/rule/InvalidRuleConfigurationException.java 0.00% <0.00%> (ø)
.../shardingsphere/data/pipeline/api/job/JobType.java 0.00% <0.00%> (ø)
...ation/query/QueryableScalingRALBackendHandler.java 0.00% <0.00%> (ø)
...tion/update/UpdatableScalingRALBackendHandler.java 0.00% <0.00%> (ø)
...ent/distsql/rql/impl/ShowRulesStatementAssert.java 100.00% <0.00%> (ø)
...peline/scenario/migration/MigrationJobAPIImpl.java 0.00% <0.00%> (ø)
... and 28 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@linghengqian linghengqian force-pushed the graalvm-native-image branch 9 times, most recently from b92b338 to 8ad4592 Compare September 22, 2022 12:50
@linghengqian linghengqian force-pushed the graalvm-native-image branch 16 times, most recently from 6be27b5 to ca840e8 Compare September 23, 2022 05:52
@linghengqian linghengqian force-pushed the graalvm-native-image branch 4 times, most recently from 1a2718b to 7487d38 Compare September 28, 2022 14:21
@linghengqian linghengqian marked this pull request as ready for review September 28, 2022 14:51
@linghengqian
Copy link
Member Author

  • Maybe a friend can give some review comments?

Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about split GraalVM to independent distribute module?

@linghengqian linghengqian force-pushed the graalvm-native-image branch 2 times, most recently from e5cef53 to fca3086 Compare October 3, 2022 07:46
@linghengqian
Copy link
Member Author

@linghengqian linghengqian force-pushed the graalvm-native-image branch 2 times, most recently from a64e877 to ba3d623 Compare October 3, 2022 08:06
@linghengqian
Copy link
Member Author

done.

Copy link
Member

@terrymanu terrymanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!

@terrymanu terrymanu added this to the 5.2.1 milestone Oct 3, 2022
@terrymanu terrymanu merged commit c92693b into apache:master Oct 3, 2022
@linghengqian linghengqian deleted the graalvm-native-image branch October 3, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants