Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "PLSR-1240 upgrade GRPC to 1.31 to avoid deadlock" #8363

Merged
merged 1 commit into from
Oct 23, 2020

Conversation

lhotari
Copy link
Member

@lhotari lhotari commented Oct 23, 2020

Reverts #8351

This reverts commit 647d3c2.

- there are grpc/protobuf version compatibility issues

- tests weren't run because of apache#8362

This reverts commit 647d3c2.
@lhotari
Copy link
Member Author

lhotari commented Oct 23, 2020

There were this kind of errors in PR #8358 builds

13:11:31.285 [main] ERROR org.apache.bookkeeper.common.component.AbstractLifecycleComponent - Failed to start Component: storage-service
java.lang.NoSuchMethodError: io.grpc.internal.DnsNameResolverProvider.newNameResolver(Ljava/net/URI;Lio/grpc/Attributes;)Lio/grpc/internal/DnsNameResolver;
	at org.apache.bookkeeper.common.resolver.ServiceNameResolverProvider.newNameResolver(ServiceNameResolverProvider.java:95) ~[org.apache.bookkeeper-stream-storage-java-client-4.10.0.jar:4.10.0]
	at org.apache.bookkeeper.common.resolver.NameResolverProviderFactory.newNameResolver(NameResolverProviderFactory.java:45) ~[org.apache.bookkeeper-stream-storage-java-client-4.10.0.jar:4.10.0]
	at io.grpc.NameResolver$Factory.newNameResolver(NameResolver.java:207) ~[io.grpc-grpc-api-1.31.0.jar:1.31.0]
	at io.grpc.NameResolver$Factory.newNameResolver(NameResolver.java:235) ~[io.grpc-grpc-api-1.31.0.jar:1.31.0]
	at io.grpc.internal.ManagedChannelImpl.getNameResolver(ManagedChannelImpl.java:701) ~[io.grpc-grpc-core-1.31.0.jar:1.31.0]
	at io.grpc.internal.ManagedChannelImpl.<init>(ManagedChannelImpl.java:606) ~[io.grpc-grpc-core-1.31.0.jar:1.31.0]

in https://github.com/apache/pulsar/runs/1297863577?check_suite_focus=true

I was assuming that protoc-gen-grpc-java.version should match grpc.version. However this led to some other issues.
Therefore I think it's better to first revert the grpc upgrade, fix the Github flow (#8362) and then reissue a PR for the grpc upgrade. The PR #8361 could also be useful when doing the grpc upgrade PR.

@sijie sijie added this to the 2.7.0 milestone Oct 23, 2020
@sijie sijie merged commit 26f2b6d into apache:master Oct 23, 2020
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Nov 13, 2020
- there are grpc/protobuf version compatibility issues

- tests weren't run because of apache#8362

This reverts commit 647d3c2.
flowchartsman pushed a commit to flowchartsman/pulsar that referenced this pull request Nov 17, 2020
- there are grpc/protobuf version compatibility issues

- tests weren't run because of apache#8362

This reverts commit 647d3c2.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants