[C++] Fix message id error if messages were sent to a partitioned topic #6938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BewareMyPower
changed the title
|
/pulsarbot run-failure-checks |
1 similar comment
|
/pulsarbot run-failure-checks |
jiazhai
approved these changes
May 12, 2020
|
Thanks @BewareMyPower for the fix. |
jiazhai
added
component/c++
release/2.5.2
type/bug
1 task
jiazhai
pushed a commit
that referenced
this pull request
May 12, 2020
) ### Motivation If messages were sent to a partitioned topic, the message id's `partition` field was always -1 because SendReceipt command only contains ledger id and entry id. ### Modifications - Add a `partition` field to `ProducerImpl` and set the `MessageId`'s `partition` field with it in `ackReceived` method later. - Add a test to check message id in send callback if messages were sent to a partitioned topic. (cherry picked from commit 15cb920)
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
…ache#6938) ### Motivation If messages were sent to a partitioned topic, the message id's `partition` field was always -1 because SendReceipt command only contains ledger id and entry id. ### Modifications - Add a `partition` field to `ProducerImpl` and set the `MessageId`'s `partition` field with it in `ackReceived` method later. - Add a test to check message id in send callback if messages were sent to a partitioned topic.
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
Jun 12, 2020
…ache#6938) ### Motivation If messages were sent to a partitioned topic, the message id's `partition` field was always -1 because SendReceipt command only contains ledger id and entry id. ### Modifications - Add a `partition` field to `ProducerImpl` and set the `MessageId`'s `partition` field with it in `ackReceived` method later. - Add a test to check message id in send callback if messages were sent to a partitioned topic. (cherry picked from commit 15cb920)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
…ache#6938) ### Motivation If messages were sent to a partitioned topic, the message id's `partition` field was always -1 because SendReceipt command only contains ledger id and entry id. ### Modifications - Add a `partition` field to `ProducerImpl` and set the `MessageId`'s `partition` field with it in `ackReceived` method later. - Add a test to check message id in send callback if messages were sent to a partitioned topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
If messages were sent to a partitioned topic, the message id's
partitionfield was always -1 because SendReceipt command only contains ledger id and entry id.Modifications
partitionfield toProducerImpland set theMessageId'spartitionfield with it inackReceivedmethod later.Verifying this change
This change is already covered by existing tests, such as
BasicEndToEndTest.testSendCallback.