use originalAuthMethod on originalAuthChecker #6870
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KannarFr
force-pushed
the
fix-original-auth-method-usage
branch
from
81f6718
to
14064e5
Compare
|
@sijie can you review it? Do it cover all cases? |
|
@KannarFr Thanks for the fix. Seems there is no test cover this case, Would you please also help provide a test for this case? |
This is the only place that I can see. |
sijie
approved these changes
May 6, 2020
|
Nvm, missed: |
jiazhai
pushed a commit
that referenced
this pull request
May 12, 2020
Huanli-Meng
pushed a commit
to Huanli-Meng/pulsar
that referenced
this pull request
May 27, 2020
Fixes apache#6873 Use originalAuthMethod on originalAuthProvider check.
addisonj
pushed a commit
to instructure/pulsar
that referenced
this pull request
Jun 12, 2020
Fixes apache#6873 Use originalAuthMethod on originalAuthProvider check. (cherry picked from commit 8381371)
huangdx0726
pushed a commit
to huangdx0726/pulsar
that referenced
this pull request
Aug 24, 2020
Fixes apache#6873 Use originalAuthMethod on originalAuthProvider check.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6873
Use originalAuthMethod on originalAuthProvider check.