Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[broker] register loadbalance znode should attempt to wait until session expired #6788

Merged
merged 1 commit into from Apr 23, 2020

Conversation

sijie
Copy link
Member

@sijie sijie commented Apr 21, 2020

Motivation

Exceptions Broker-znode owned by different zk-session is commonly seen when a broker
starts up in Kubernetes environment. That's because the previous znode is not expired.

…ion expired

*Motivation*

Exceptions `Broker-znode owned by different zk-session` is commonly seen when a broker
starts up in Kubernetes environment. That's because the previous znode is not expired.
@sijie sijie added type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages area/broker release/2.5.2 labels Apr 21, 2020
@sijie sijie added this to the 2.6.0 milestone Apr 21, 2020
@sijie sijie self-assigned this Apr 21, 2020
@sijie
Copy link
Member Author

sijie commented Apr 22, 2020

/pulsarbot run-failure-checks

Copy link
Contributor

@merlimat merlimat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is fine though the culprit of the issue seems to rely on ZK.

I've seen in multiple occasions (on K8S env) ZK leaders election taking ~2min. That would take the brokers down with the sessions still there. That issue is still there.

@sijie sijie merged commit b119611 into apache:master Apr 23, 2020
@sijie sijie deleted the startup_wait_session_expired branch April 23, 2020 00:47
cdbartholomew pushed a commit to kafkaesque-io/pulsar that referenced this pull request Apr 29, 2020
…ion expired (apache#6788)

*Motivation*

Exceptions `Broker-znode owned by different zk-session` is commonly seen when a broker
starts up in Kubernetes environment. That's because the previous znode is not expired.
addisonj pushed a commit to instructure/pulsar that referenced this pull request May 7, 2020
…ion expired (apache#6788)

*Motivation*

Exceptions `Broker-znode owned by different zk-session` is commonly seen when a broker
starts up in Kubernetes environment. That's because the previous znode is not expired.
jiazhai pushed a commit that referenced this pull request May 8, 2020
…ion expired (#6788)

*Motivation*

Exceptions `Broker-znode owned by different zk-session` is commonly seen when a broker
starts up in Kubernetes environment. That's because the previous znode is not expired.
(cherry picked from commit b119611)
huangdx0726 pushed a commit to huangdx0726/pulsar that referenced this pull request Aug 24, 2020
…ion expired (apache#6788)

*Motivation*

Exceptions `Broker-znode owned by different zk-session` is commonly seen when a broker
starts up in Kubernetes environment. That's because the previous znode is not expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/broker release/2.5.2 type/enhancement The enhancements for the existing features or docs. e.g. reduce memory usage of the delayed messages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants