New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] [test] Fix flaky test ReplicatorTest #22594
[fix] [test] Fix flaky test ReplicatorTest #22594
Conversation
be08b10
to
ff6afa9
Compare
I think this could be handled with a comment instead. Renaming the file will make following changes harder and I don't think that it provides much clarity. Calling something "dangerous" is very vague and always requires further explanation. That's why comments in the test class or in Pulsar documentation are a better approach to tackle this. |
Makes sense |
pulsar-broker/src/main/java/org/apache/pulsar/broker/admin/impl/NamespacesBase.java
Outdated
Show resolved
Hide resolved
pulsar-broker/src/test/java/org/apache/pulsar/broker/admin/NamespaceAuthZTest.java
Outdated
Show resolved
Hide resolved
ff6afa9
to
e68575d
Compare
@poorbarcode I disabled one problematic test causing OOME in #22586 . Would it be fine to include the revert in this PR or is it better to handle that separately? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I will review the test |
9a85713
to
d5c4452
Compare
Rebase master |
(cherry picked from commit 6fdc0e3)
(cherry picked from commit 6fdc0e3)
Motivation
There are two tests that are not normal operations when using Geo-Replication with a global metadata store, which is should be denied in a production pulsar cluster. they are very dangerous, which leads to a lot of topic deletion and makes namespace policies being incorrect, making other tests in the same class flaky
Replicatortest.testConfigChange
ReplicatorGlobalNSTest .testRemoveLocalClusterOnGlobalNamespace
Modifications
ReplicatorGlobalNSTest
to describe it as the class to run no-normal tests.Replicatortest.testConfigChange
intoReplicatorGlobalNSTest
ReplicatorGlobalNSTest. testForcefullyTopicDeletion
intoReplicatortest
Documentation
doc
doc-required
doc-not-needed
doc-complete
Matching PR in forked repository
PR in forked repository: x