[fix][broker] Fix geo-replication admin client url #22584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodece
approved these changes
Apr 28, 2024
hanmz
approved these changes
Apr 30, 2024
Coselding
approved these changes
May 6, 2024
Demogorgon314
force-pushed
the
Demogorgon314/fix-geo-replication-admin-url
branch
from
7deccc7
to
f2a5af4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When we only set the TLS URLs for
ClusterDataand set thebrokerClientTlsEnabledtotrue, the admin client for geo-replication will be failed to create because the else if block(StringUtils.isEmpty(data.getServiceUrl())) logic is wrong.Modifications
Documentation
docdoc-requireddoc-not-neededdoc-complete