[improve][broker] Exclude producers for geo-replication from publishers field of topic stats #22556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
massakam
added
type/enhancement
lhotari
reviewed
Apr 22, 2024
...-broker/src/main/java/org/apache/pulsar/broker/service/nonpersistent/NonPersistentTopic.java
Outdated
Show resolved
Hide resolved
lhotari
reviewed
Apr 22, 2024
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/PersistentTopic.java
Outdated
Show resolved
Hide resolved
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #22556 +/- ##
============================================
+ Coverage 73.57% 73.87% +0.29%
+ Complexity 32624 2744 -29880
============================================
Files 1877 1885 +8
Lines 139502 140516 +1014
Branches 15299 15450 +151
============================================
+ Hits 102638 103804 +1166
+ Misses 28908 28656 -252
- Partials 7956 8056 +100
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
@lhotari PTAL |
massakam
force-pushed
the
exclude-repl-producers
branch
from
442bb30
to
6119eac
Compare
|
Resolved conflicts. |
massakam
force-pushed
the
exclude-repl-producers
branch
3 times, most recently
from
96aa9f6
to
342d63e
Compare
massakam
force-pushed
the
exclude-repl-producers
branch
from
342d63e
to
14a4e8b
Compare
poorbarcode
approved these changes
Apr 26, 2024
nkurihar
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22442
Motivation
Please refer to #22442.
Modifications
Exclude producers for geo-replication from the
publishersfield in topic-stats and broker-stats.Verifying this change
Documentation
docdoc-requireddoc-not-neededdoc-complete