Event time based compaction #22517
Draft
Event time based compaction #22517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@marekczajkowski Please add the following content to your PR description and select a checkbox: |
lhotari
reviewed
May 6, 2024
| public static List<ImmutableTriple<MessageId, String, Integer>> extractIdsAndKeysAndSize( | ||
| RawMessage msg) | ||
| throws IOException { | ||
| return extractMessageCompactionData(msg).stream() |
There was a problem hiding this comment.
Java Streams are intentionally avoided in Pulsar code that is performance critical.
I think it's better to remove this completely since RawBatchConverter isn't part of the public API.
Comment on lines
+1296
to
+1297
|
|
||
| compactionServiceFactoryClassName=org.apache.pulsar.compaction.EventTimeCompactionServiceFactory |
There was a problem hiding this comment.
I guess this isn't intended to be part of the change?
There was a problem hiding this comment.
I'd call this PublishingOrderCompactor and call the other one EventTimeOrderCompactor. I don't think that TwoPhase is needed in the class name since that's an implementation detail.
There was a problem hiding this comment.
I think EventTimeOrderCompactor could be a better name?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft with Event time based topic compaction