Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix][build][branch-2.10] Fix ci-license check #20505

Merged
merged 2 commits into from
Jun 6, 2023

Conversation

RobertIndie
Copy link
Member

Motivation

There is an error in the ci-license on branch-2.10:

Error:  Failed to execute goal org.apache.nifi:nifi-nar-maven-plugin:1.5.0:nar (default-nar) on project tiered-storage-jcloud: The plugin org.apache.nifi:nifi-nar-maven-plugin:1.5.0 requires Maven version 3.6.3 -> [Help 1]

More detail here.

Modifications

  • Use maven 3.6.3 in ci-license

Does this pull request potentially affect one of the following parts:

If the box was checked, please highlight the changes

  • Dependencies (add or upgrade a dependency)
  • The public API
  • The schema
  • The default values of configurations
  • The threading model
  • The binary protocol
  • The REST endpoints
  • The admin CLI options
  • The metrics
  • Anything that affects deployment

Documentation

  • doc
  • doc-required
  • doc-not-needed
  • doc-complete

Matching PR in forked repository

PR in forked repository:

@RobertIndie RobertIndie self-assigned this Jun 6, 2023
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jun 6, 2023
@lhotari
Copy link
Member

lhotari commented Jun 6, 2023

I looks like the license check build didn't pass.
https://github.com/apache/pulsar/actions/runs/5184392887/jobs/9343245955?pr=20505

Instead of using Maven 3.6.1 or 3.6.3, I think that we should upgrade license plugin to 4.1 version like it is in master branch.

@lhotari lhotari changed the title [fix][build][branch-2.10] Use maven 3.6.3 for ci-license check [fix][build][branch-2.10] Fix ci-license check Jun 6, 2023
@lhotari
Copy link
Member

lhotari commented Jun 6, 2023

License check passed now: https://github.com/apache/pulsar/actions/runs/5184989687/jobs/9344418578?pr=20505 . Merging this PR to branch-2.10

@lhotari lhotari merged commit 832d7e0 into apache:branch-2.10 Jun 6, 2023
35 of 41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs ready-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants