Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature][connectors][PIP-193] Support Transform Function with LocalRunner #17445

Merged
merged 1 commit into from Sep 8, 2022

Conversation

cbornet
Copy link
Contributor

@cbornet cbornet commented Sep 3, 2022

Master Issue: #16739

Motivation

This adds support for Transform Function in LocalRunner

Modifications

see below

Verifying this change

  • Make sure that the change passes the CI checks.

This change added tests and can be verified as follows:

  • Run testPulsarSinkWithFunction

Does this pull request potentially affect one of the following parts:

no

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

Check the box below or label this PR directly.

Need to update docs?

  • doc-required
    (Your PR needs to update docs and you will update later)

  • doc-not-needed
    (Please explain why)

  • doc
    (Your PR contains doc changes)

  • doc-complete
    (Docs have been already added)

@github-actions github-actions bot added the doc-required Your PR changes impact docs and you will update later. label Sep 3, 2022
@cbornet cbornet force-pushed the pip193-localrun branch 3 times, most recently from 5743c92 to 89fc5f9 Compare September 5, 2022 14:21
Copy link
Contributor

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cbornet
Copy link
Contributor Author

cbornet commented Sep 6, 2022

/pulsarbot run-failure-checks

Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli eolivelli merged commit 327648c into apache:master Sep 8, 2022
@cbornet cbornet deleted the pip193-localrun branch September 8, 2022 10:54
nicoloboschi pushed a commit to nicoloboschi/pulsar that referenced this pull request Sep 8, 2022
nicoloboschi pushed a commit to datastax/pulsar that referenced this pull request Sep 9, 2022
@momo-jun
Copy link
Contributor

@cbornet It will help users a lot if you can add the docs for this feature. Do you have any plans on that?

@momo-jun
Copy link
Contributor

Hi @cbornet, Feel free to share your plans on adding the docs to the next version of docs and let me know anything I can help with.

@Anonymitaet Anonymitaet added doc-complete Your PR changes impact docs and the related docs have been already added. and removed doc-required Your PR changes impact docs and you will update later. labels May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/connector doc-complete Your PR changes impact docs and the related docs have been already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants