Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[branch-2.9] Rename test file name from *Test2.java to *Test.java to run all tests correctly #17048

Merged
merged 3 commits into from Sep 13, 2022

Conversation

equanz
Copy link
Contributor

@equanz equanz commented Aug 10, 2022

Fixes #16854

cherry-pick: #13644

Motivation

It seems some test cases like **/*Test2.java aren't run on the default test lifecycle.
This issue is caused by #10148. I'd like to fix it.

Modifications

Originally:

Additionally:

Verifying this change

  • Make sure that the change passes the CI checks.

This change is a trivial rework / code cleanup without any test coverage.

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API: (no)
  • The schema: (no)
  • The default values of configurations: (no)
  • The wire protocol: (no)
  • The rest endpoints: (no)
  • The admin cli options: (no)
  • Anything that affects deployment: (no)

Documentation

  • no-need-doc

equanz and others added 3 commits August 10, 2022 23:16
…ests correctly (apache#13644)

* test: rename test class

* fix: fix to follow existing test cases

* test: fix to follow existing production codes
@equanz
Copy link
Contributor Author

equanz commented Aug 11, 2022

/pulsarbot run-failure-checks

@mattisonchao mattisonchao merged commit 4d628a9 into apache:branch-2.9 Sep 13, 2022
@equanz equanz deleted the fix_to_run_all_tests_2.9 branch September 13, 2022 02:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants