Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[improve][security] CVE-2022-33915 is false positive #16415

Closed
wants to merge 3 commits into from

Conversation

tisonkun
Copy link
Member

@tisonkun tisonkun commented Jul 6, 2022

Signed-off-by: tison wander4096@gmail.com

Motivation

CVE-2022-33915 is about Amazon AWS hotpatch. We don't use that version and the failure reported by OWASP is false positive.

Reported when preparing patch #16320.

Modifications

Suppress CVE-2022-33915.

Verifying this change

  • Make sure that the change passes the CI checks.

Does this pull request potentially affect one of the following parts:

If yes was chosen, please highlight the changes

  • Dependencies (does it add or upgrade a dependency): (yes / no)
  • The public API: (yes / no)
  • The schema: (yes / no / don't know)
  • The default values of configurations: (yes / no)
  • The wire protocol: (yes / no)
  • The rest endpoints: (yes / no)
  • The admin cli options: (yes / no)
  • Anything that affects deployment: (yes / no / don't know)

Documentation

  • doc-not-needed

Signed-off-by: tison <wander4096@gmail.com>
@github-actions github-actions bot added the doc-not-needed Your PR changes do not impact docs label Jul 6, 2022
@shoothzj
Copy link
Member

shoothzj commented Jul 6, 2022

can we remove the log4j1 dependency?

@tisonkun
Copy link
Member Author

tisonkun commented Jul 6, 2022

@shoothzj sorry I make a wrong version number, this is about log4j-core-2.17.1.

@tisonkun tisonkun marked this pull request as ready for review July 6, 2022 08:24
@tisonkun
Copy link
Member Author

tisonkun commented Jul 6, 2022

@nicoloboschi @shoothzj tests failed on flaky cases. You may merge this patch since "CI - Misc - OWASP Dependency Check / owasp-dep-check" passed or help re-trigger the failed jobs :)

@merlimat merlimat added this to the 2.11.0 milestone Jul 6, 2022
@RobertIndie
Copy link
Member

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Jul 7, 2022

/pulsarbot run-failure-checks

@tisonkun
Copy link
Member Author

tisonkun commented Jul 7, 2022

ping @nicoloboschi whether this CI status is valid to move forward?

@RobertIndie
Copy link
Member

whether this CI status is valid to move forward?

@tisonkun The CI is broken by CI - Unit - Brokers - Broker Group 1 .
I have reported the flaky tests: #16427 , #16444 . And a suspected CI-related issue: #16445

I'm trying to rerun the CI checks again.

@tisonkun
Copy link
Member Author

tisonkun commented Jul 7, 2022

@RobertIndie Thank you! However, it seems "Pulsar CI / CI - Unit - Brokers - Broker Group 1" still failed. I don't think we have to rerun until it passes since it's obvious unrelated to this patch. I agree that we should reduce flaky tests, though.

@tisonkun
Copy link
Member Author

tisonkun commented Jul 8, 2022

It seems OWASP fixes this false positive report. Pending to close...

@tisonkun tisonkun closed this Jul 8, 2022
@tisonkun tisonkun deleted the suppress-CVE-2022-33915 branch July 8, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/security doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants