Skip to content

[Branch-2.7][Cherry-pick] Fix lost compaction data due to compaction properties missed during reset-cursor. #16404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 6, 2022

Conversation

Technoboy-
Copy link
Contributor

Cherry-pick #12698

Motivation

Fix lost compaction data due to compaction properties missed during reset-cursor.

  1. The compaction reader will seek to the earliest position to read data from the topic, but the compaction properties missed during the cursor reset, this will lead to the inited compaction subscribe without compaction horizon, so the compaction reader will skip the last compacted data. It will only happen when init the compaction subscription, so can introduced by the loadbalance or topic unloading manually.

  2. Advance the cursor should also keep the properties, otherwise, the properties will lost during the cursor trimming.

Changes

  1. Keep the properties for resetting the cursor while the cursor is for data compaction.
  2. Copy the properties to the new mark delete entry while advance the cursor, this is triggered byt the managed ledger internal, so it's not only for compacted topic, the internal task should not loss the properties when trimming the cursor.

Tests

New tests added to make sure the compaction will not loss data during topic unloading and the reader can read all the compacted data after the compaction task complete

Documentation

Check the box below and label this PR (if you have committer privilege).

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

Sorry, something went wrong.

@Technoboy- Technoboy- force-pushed the cherry-pick-12698 branch from 6fb61e7 to aabb2ce Compare July 6, 2022 02:18
@Technoboy- Technoboy- self-assigned this Jul 6, 2022
@Technoboy- Technoboy- added the doc-not-needed Your PR changes do not impact docs label Jul 6, 2022
@Technoboy- Technoboy- merged commit 77d5bb5 into apache:branch-2.7 Jul 6, 2022
@Technoboy- Technoboy- deleted the cherry-pick-12698 branch August 10, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-not-needed Your PR changes do not impact docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants