New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix][broker]Close publishLimiter when disable it #15520
Merged
Technoboy-
merged 2 commits into
apache:master
from
AnonHxy:opt_close_publishRatelimiter_update
May 11, 2022
Merged
[fix][broker]Close publishLimiter when disable it #15520
Technoboy-
merged 2 commits into
apache:master
from
AnonHxy:opt_close_publishRatelimiter_update
May 11, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/pulsarbot run-failure-checks |
Technoboy-
reviewed
May 10, 2022
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/AbstractTopic.java
Outdated
Show resolved
Hide resolved
Technoboy-
added
type/bug
The PR fixed a bug or issue reported a bug
area/broker
release/2.10.1
labels
May 11, 2022
AnonHxy
force-pushed
the
opt_close_publishRatelimiter_update
branch
from
May 11, 2022 09:07
63c6db6
to
6bbeb80
Compare
Technoboy-
approved these changes
May 11, 2022
Jason918
approved these changes
May 11, 2022
/pulsarbot run-failure-checks |
codelipenghui
pushed a commit
that referenced
this pull request
May 20, 2022
(cherry picked from commit e8c971a)
mattisonchao
pushed a commit
that referenced
this pull request
May 25, 2022
(cherry picked from commit e8c971a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.9
Archived: 2.9 is end of life
cherry-picked/branch-2.10
doc-not-needed
Your PR changes do not impact docs
release/2.9.3
release/2.10.1
type/bug
The PR fixed a bug or issue reported a bug
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Close
topicPublishRateLimiter
when it is disabled to prevent resource leakagesModifications
Close
topicPublishRateLimiter
when it change from enable to disableVerifying this change
Make sure that the change passes the CI checks.
no-need-doc
(Please explain why)