Fix incorrect entryId in warn log when reading entry from tiered storage #14685
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
congbobo184,
michaeljmarshall,
eolivelli,
codelipenghui and
zymap
|
@hangc0276:Thanks for your contribution. For this PR, do we need to update docs? |
|
@hangc0276 seems that we do not update docs for this PR？ |
@Anonymitaet Yes, it doesn't need doc updates. |
codelipenghui
approved these changes
Mar 15, 2022
|
@hangc0276:Thanks for providing doc info! |
michaeljmarshall
approved these changes
Mar 15, 2022
michaeljmarshall
added
type/cleanup
dlg99
approved these changes
Mar 15, 2022
hezhangjian
approved these changes
Mar 15, 2022
Technoboy-
approved these changes
Mar 15, 2022
mattisonchao
approved these changes
Mar 15, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Mar 18, 2022
### Motivation When read offload data failed, it prints a warn log. However, the actual read entryId doesn't print correctly, which will makes hard to debug. ``` WARN org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreBackedReadHandleImpl - Read an unexpected entry id [] which is smaller than the next expected entry id 49648, seeking to the right position ``` ### Modification 1. Print correct actual entryId (cherry picked from commit bcba273)
codelipenghui
pushed a commit
that referenced
this pull request
Mar 18, 2022
### Motivation When read offload data failed, it prints a warn log. However, the actual read entryId doesn't print correctly, which will makes hard to debug. ``` WARN org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreBackedReadHandleImpl - Read an unexpected entry id [] which is smaller than the next expected entry id 49648, seeking to the right position ``` ### Modification 1. Print correct actual entryId (cherry picked from commit bcba273)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
### Motivation When read offload data failed, it prints a warn log. However, the actual read entryId doesn't print correctly, which will makes hard to debug. ``` WARN org.apache.bookkeeper.mledger.offload.jcloud.impl.BlobStoreBackedReadHandleImpl - Read an unexpected entry id [] which is smaller than the next expected entry id 49648, seeking to the right position ``` ### Modification 1. Print correct actual entryId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When read offload data failed, it prints a warn log. However, the actual read entryId doesn't print correctly, which will makes hard to debug.
Modification