If mark-delete operation fails, mark the cursor as "dirty" #14256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
the
type/enhancement
merlimat
requested review from
addisonj,
rdhabalia,
hangc0276 and
codelipenghui
|
@merlimat:Thanks for your contribution. For this PR, do we need to update docs? |
1 similar comment
|
@merlimat:Thanks for your contribution. For this PR, do we need to update docs? |
merlimat
added
doc-not-needed
lhotari
approved these changes
Feb 12, 2022
eolivelli
approved these changes
Feb 12, 2022
mattisonchao
approved these changes
Feb 13, 2022
Jason918
approved these changes
Feb 13, 2022
codelipenghui
approved these changes
Feb 13, 2022
lhotari
pushed a commit
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit 8928c34)
lhotari
pushed a commit
that referenced
this pull request
Feb 14, 2022
(cherry picked from commit 8928c34)
gaoran10
added
release/2.9.2
component/bookkeeper
and removed
release/2.9.3
component/bookkeeper
labels
lhotari
pushed a commit
that referenced
this pull request
Apr 6, 2022
(cherry picked from commit 8928c34)
lhotari
added
cherry-picked/branch-2.7
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When the mark delete operation fails, we need to identify the cursor as "dirty", to ensure the in-memory position is eventually flushed to disk (even if there are no new incoming acks).