Fixed detecting number of NICs in EC2 #14252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merlimat
added
type/bug
merlimat
requested review from
rdhabalia,
hangc0276,
codelipenghui,
shoothzj,
zymap and
michaeljmarshall
michaeljmarshall
approved these changes
Feb 12, 2022
codelipenghui
approved these changes
Feb 12, 2022
merlimat
added a commit
that referenced
this pull request
Feb 12, 2022
merlimat
added a commit
that referenced
this pull request
Feb 12, 2022
merlimat
added
cherry-picked/branch-2.8
2 tasks
| // Check the type to make sure it's ethernet (type "1") | ||
| try { | ||
| String type = new String(Files.readAllBytes(path.resolve("type")), StandardCharsets.UTF_8).trim(); | ||
| return Integer.parseInt(type) == 1; |
There was a problem hiding this comment.
When that happens, we're ignoring that NIC and it causes that we cannot even manually override the NIC capacity in broker.conf
I see now that the point was to make it so it could be overridden.
|
Given that this change can lead to new and verbose error logs, we should highlight in the release notes how to mitigate this error. |
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
In some EC2 instances we get an error when trying to read the NIC speed:
When that happens, we're ignoring that NIC and it causes that we cannot even manually override the NIC capacity in broker.conf, since the value that is configured is adjusted on the number of NICs. When we ignore that, the number gets then multiplied by 0.