KeyShared stickyHashRange subscription: prevent stuck subscription in case of consumer restart #14014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of consumer restart
eolivelli
requested review from
codelipenghui and
lhotari
and removed request for
codelipenghui
|
Actually @codelipenghui helped me in finding out the problem and suggesting the fix |
Thank you @codelipenghui for helping out! |
Messages are not lost, since they're still tracked in backlog. It's just stuck. |
This is correct, for instance you can read them from another partition or you can reset the subscription to an earlier offset. |
eolivelli
changed the title
|
@merlimat I updated the title |
You'd just need to reconnect your consumers (eg: unload the topic) to get them unblocked. |
merlimat
approved these changes
Jan 28, 2022
codelipenghui
approved these changes
Jan 29, 2022
Demogorgon314
approved these changes
Jan 29, 2022
codelipenghui
pushed a commit
that referenced
this pull request
Jan 30, 2022
… case of consumer restart (#14014) ### Motivation When using KeyShared subscription with `stickyHashRange` it is possible to a stuck subscription while restarting the consumers. This bug is not a regression in 2.10, the problem is present also in Pulsar 2.8 (and probably older versions) ### Modifications add the entry to the list of messaged to be redelivered (cherry picked from commit da9e806)
zymap
pushed a commit
that referenced
this pull request
Jan 30, 2022
… case of consumer restart (#14014) When using KeyShared subscription with `stickyHashRange` it is possible to a stuck subscription while restarting the consumers. This bug is not a regression in 2.10, the problem is present also in Pulsar 2.8 (and probably older versions) add the entry to the list of messaged to be redelivered (cherry picked from commit da9e806)
Nicklee007
pushed a commit
to Nicklee007/pulsar
that referenced
this pull request
Apr 20, 2022
… case of consumer restart (apache#14014) ### Motivation When using KeyShared subscription with `stickyHashRange` it is possible to a stuck subscription while restarting the consumers. This bug is not a regression in 2.10, the problem is present also in Pulsar 2.8 (and probably older versions) ### Modifications add the entry to the list of messaged to be redelivered
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
When using KeyShared subscription with
stickyHashRangeit is possible to a stuck subscription while restarting the consumers.This bug is not a regression in 2.10, the problem is present also in Pulsar 2.8 (and probably older versions)
Modifications
add the entry to the list of messaged to be redelivered
Verifying this change
this patch adds a test that cover the change
Documentation
no-need-doc