New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trim configuration value string which contains blank prefix or suffix #13984
Merged
merlimat
merged 1 commit into
apache:master
from
hangc0276:chenhang/fix_configuration_string_contains_blank_suffix_or_prefix
Jan 27, 2022
Merged
Trim configuration value string which contains blank prefix or suffix #13984
merlimat
merged 1 commit into
apache:master
from
hangc0276:chenhang/fix_configuration_string_contains_blank_suffix_or_prefix
Jan 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hangc0276
requested review from
MarvinCai,
rdhabalia,
315157973,
codelipenghui,
Jason918,
shoothzj and
zymap
January 27, 2022 10:17
Jason918
approved these changes
Jan 27, 2022
mattisonchao
approved these changes
Jan 27, 2022
codelipenghui
approved these changes
Jan 27, 2022
RobertIndie
approved these changes
Jan 27, 2022
gaozhangmin
approved these changes
Jan 27, 2022
merlimat
approved these changes
Jan 27, 2022
codelipenghui
added
cherry-picked/branch-2.8
Archived: 2.8 is end of life
cherry-picked/branch-2.9
Archived: 2.9 is end of life
and removed
cherry-picked/branch-2.8
Archived: 2.8 is end of life
labels
Jan 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/broker
cherry-picked/branch-2.7
Archived: 2.7 is end of life
cherry-picked/branch-2.8
Archived: 2.8 is end of life
cherry-picked/branch-2.9
Archived: 2.9 is end of life
doc-not-needed
Your PR changes do not impact docs
release/2.7.5
release/2.8.3
release/2.9.2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
For
broker.conf
andproxy.conf
, if user configure value string which contains blank prefix or suffix, it will parse failed for related configuration and cause broker startup failed.For example, if user configure the
metadataStoreUrl=" zk:my-zk-1:2181,my-zk-2:2181,my-zk-3:2181 "
, we will connect to zookeeper server failed due to the blank suffix, and it's hard to debug.Modifications
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
Check the box below or label this PR directly (if you have committer privilege).
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)