Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the deadlock while using zookeeper thread to create ledger #13744

Merged
merged 3 commits into from Jan 14, 2022
Merged

Fix the deadlock while using zookeeper thread to create ledger #13744

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1849074
Fix the deadlock while using zookeeper thread to create ledger
codelipenghui Jan 13, 2022
9a943f1
Apply the executor in the createLedgerAfterClosed method
codelipenghui Jan 13, 2022
8345cb3
Move comments
codelipenghui Jan 13, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 4 additions & 1 deletion managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
View file
Open in desktop
Expand Up @@ -1638,7 +1638,10 @@ synchronized void createLedgerAfterClosed() {
STATE_UPDATER.set(this, State.CreatingLedger);
this.lastLedgerCreationInitiationTimestamp = System.currentTimeMillis();
mbean.startDataLedgerCreateOp();
asyncCreateLedger(bookKeeper, config, digestType, this, Collections.emptyMap());
// Use the executor here is to avoid use the Zookeeper thread to create the ledger which will lead
// to deadlock at the zookeeper client, details to see https://github.com/apache/pulsar/issues/13736
this.executor.execute(() ->
asyncCreateLedger(bookKeeper, config, digestType, this, Collections.emptyMap()));
}
}

Expand Down