Cipher params not work in KeyStoreSSLContext #13322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/pulsarbot run-failure-checks |
hangc0276
approved these changes
Dec 15, 2021
hangc0276
requested review from
codelipenghui,
gaoran10,
MarvinCai and
zymap
codelipenghui
approved these changes
Dec 15, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
### Motivation The Cipher params not work in KeyStoreSSLContext. ### Modifications - if cipher params is null, use `sslEngine.getSupportedCipherSuites()`, else use the cipher params - make fields final - remove unused throw exception
codelipenghui
pushed a commit
that referenced
this pull request
Dec 22, 2021
### Motivation The Cipher params not work in KeyStoreSSLContext. ### Modifications - if cipher params is null, use `sslEngine.getSupportedCipherSuites()`, else use the cipher params - make fields final - remove unused throw exception (cherry picked from commit 8625ffe)
codelipenghui
added
cherry-picked/branch-2.8
lhotari
pushed a commit
that referenced
this pull request
Dec 23, 2021
### Motivation The Cipher params not work in KeyStoreSSLContext. ### Modifications - if cipher params is null, use `sslEngine.getSupportedCipherSuites()`, else use the cipher params - make fields final - remove unused throw exception (cherry picked from commit 8625ffe)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Cipher params not work in KeyStoreSSLContext.
Modifications
sslEngine.getSupportedCipherSuites(), else use the cipher paramsDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
no-need-docIt's a bug fix, no need doc