pulsar admin exposes secret for source and sink #13059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
freeznet
approved these changes
Dec 1, 2021
freeznet
requested review from
hangc0276,
codelipenghui,
tuteng and
wolfstudy
|
For the doc side, I've confirmed w/ @freeznet, this PR is similar to #12950 (comment) Hi @nlu90 same comments for you: #12950 (comment) |
Anonymitaet
added
doc
merlimat
approved these changes
Dec 1, 2021
tuteng
approved these changes
Dec 1, 2021
hangc0276
approved these changes
Dec 2, 2021
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
### Motivation Follow-up fix of apache#12950 for apache#12834 It turns out the Source and Sink doesn't inherit from Function cmd, so we need to add the api separately. ### Modifications add the `--secrets` argument into `pulsar-admin [source|sink] create/update/localrun` command
codelipenghui
pushed a commit
that referenced
this pull request
Dec 21, 2021
### Motivation Follow-up fix of #12950 for #12834 It turns out the Source and Sink doesn't inherit from Function cmd, so we need to add the api separately. ### Modifications add the `--secrets` argument into `pulsar-admin [source|sink] create/update/localrun` command (cherry picked from commit e888c29)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Follow-up fix of #12950 for #12834
It turns out the Source and Sink doesn't inherit from Function cmd, so we need to add the api separately.
Modifications
add the
--secretsargument intopulsar-admin [source|sink] create/update/localruncommandVerifying this change
Does this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changes--secretsargument for submitting/updating sources/sinksDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)