Fix namespace policy override ignored when creating subscription #12699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .defaultNumPartitions(3) | ||
| .build()); | ||
|
|
||
| admin.topics().createSubscription(topicString + "-partition-0", subscriptionName, MessageId.earliest); |
There was a problem hiding this comment.
Do you want to subscribe a to specific partition?
There was a problem hiding this comment.
Yes that's the intent. I've seen it done here so I guess it's OK.
Also this way the topic is created by pulsar().getBrokerService().getTopic() in internalCreateSubscriptionForNonPartitionedTopic instead of pulsar().getBrokerService().fetchPartitionedTopicMetadataCheckAllowAutoCreationAsync() when you don't specify a partition.
There was a problem hiding this comment.
Sorry, I don't understand why change the namespace level policy for topic auto-creation to create partitioned topic with 3 partitions, but here check if able to subscribe to one partition, looks like not able to ensure the partitioned topic has been created?
There was a problem hiding this comment.
Oh, I see. This test doesn't really make sense. I removed it.
There was a problem hiding this comment.
Note that currently it's possible to create a topic partition from the subscription creation without the full partitioned topic being created. Is it OK to be able to do that ?
There was a problem hiding this comment.
@codelipenghui is it OK for you ?
nicoloboschi
approved these changes
Nov 9, 2021
cbornet
force-pushed
the
auto-topic-subscription
branch
2 times, most recently
from
eebbe33
to
6c5e81f
Compare
PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
cbornet
force-pushed
the
auto-topic-subscription
branch
from
6c5e81f
to
cda14f4
Compare
lhotari
approved these changes
Dec 9, 2021
merlimat
approved these changes
Dec 9, 2021
lhotari
pushed a commit
that referenced
this pull request
Dec 10, 2021
) PR #6471 introduced the possibility to set auto topic creation settings at the namespace level PR #6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in #6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation (cherry picked from commit 965a80f)
lhotari
added
cherry-picked/branch-2.8
lhotari
pushed a commit
that referenced
this pull request
Dec 10, 2021
) PR #6471 introduced the possibility to set auto topic creation settings at the namespace level PR #6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in #6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation (cherry picked from commit 965a80f)
nicoloboschi
pushed a commit
to datastax/pulsar
that referenced
this pull request
Dec 10, 2021
…che#12699) PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation (cherry picked from commit 965a80f) (cherry picked from commit a034d14)
fxbing
pushed a commit
to fxbing/pulsar
that referenced
this pull request
Dec 19, 2021
…che#12699) PR apache#6471 introduced the possibility to set auto topic creation settings at the namespace level PR apache#6685 is a fix to take into account the auto topic creation setting when creating a subscription but it uses the broker configuration and doesn't see the namespace level setting that was introduced in apache#6471 This fix uses the method that fetches config overrides in ZK instead of the one from the broker configuration. This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
PR #6471 introduced the possibility to set auto topic creation settings at the namespace level
PR #6685 is a fix to take into account the auto topic creation setting when creating a subscription
but it uses the broker configuration and doesn't see the namespace level setting that was introduced in #6471
Modifications
This fix uses the
BrokerServiceisAllowAutoTopicCreationmethod that fetches config overrides in ZK instead of the one from the broker configuration.This way the method of the pulsar-admin uses the value set for the namespace for auto-topic-creation
Verifying this change
This change added tests and can be verified as follows:
PersistentTopicsBase.javaand the tests won't pass anymoreDoes this pull request potentially affect one of the following parts:
If
yeswas chosen, please highlight the changesDocumentation
Check the box below and label this PR (if you have committer privilege).
Need to update docs?
doc-requiredno-need-docIt's a fix
doc