New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update compaction metrics in 282 #11896
Conversation
@Technoboy- @Anonymitaet Please help review the changes and leave a comment if anything should be modified. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR modifies docs for master
. Will you modify docs for 2.8.2?
| pulsar_compaction_duration_time_in_mills | Gauge | The duration time of compaction | | ||
| pulsar_compaction_read_throughput | Gauge | The read throughput of compaction | | ||
| pulsar_compaction_write_throughput | Gauge | The write throughput of compaction | | ||
| pulsar_in_bytes_total | Counter | The total number of messages in bytes received for this topic. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pulsar_in_bytes_total | Counter | The total number of messages in bytes received for this topic. | | |
| pulsar_in_bytes_total | Counter | The total number of messages received for this topic (in bytes). | |
if agree, please update all, thanks
@Anonymitaet I prefer to not use the parenthesis, that way, "in bytes" looks like a note. The main info in this sentence is still "the total number of messages". |
@Anonymitaet I modified the doc in 2.8.2, and then I updated the changes to master. So this pr covers changes to both versions. |
This is a follow-up of #11739.