Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade aircompressor to 0.20 #11790

Merged

Conversation

hangc0276
Copy link
Contributor

Fix #11789

Modification

  1. upgrade aircompressor from 0.19 to 0.20

@codelipenghui codelipenghui added this to the 2.9.0 milestone Aug 26, 2021
Copy link
Contributor

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eolivelli
Copy link
Contributor

can you follow up with a PR that contains a "git revert" of #11594 ?

@hangc0276
Copy link
Contributor Author

can you follow up with a PR that contains a "git revert" of #11594 ?

@eolivelli Ok, i am working to revert #11594 , but i will keep the tests.

@eolivelli
Copy link
Contributor

but i will keep the tests.
great idea !

@hangc0276 hangc0276 merged commit 051f52d into apache:master Aug 26, 2021
hangc0276 added a commit that referenced this pull request Aug 26, 2021
…r upgrade to 0.20 (#11792)

### Motivation
Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so #11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and #11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert #11594 to avoid copy data to direct buffer to improve performance.

### Modification
1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression #11594, but keep the tests.
hangc0276 added a commit that referenced this pull request Aug 26, 2021
Fix #11789

### Modification
upgrade aircompressor from 0.19 to 0.20

(cherry picked from commit 051f52d)
hangc0276 added a commit that referenced this pull request Aug 26, 2021
…r upgrade to 0.20 (#11792)

### Motivation
Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so #11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and #11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert #11594 to avoid copy data to direct buffer to improve performance.

### Modification
1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression #11594, but keep the tests.

(cherry picked from commit cc1b983)
@hangc0276 hangc0276 added the cherry-picked/branch-2.8 Archived: 2.8 is end of life label Aug 26, 2021
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
Fix apache#11789

### Modification
upgrade aircompressor from 0.19 to 0.20
bharanic-dev pushed a commit to bharanic-dev/pulsar that referenced this pull request Mar 18, 2022
…r upgrade to 0.20 (apache#11792)

### Motivation
Due to aircompressor 0.19 can't work with heap buffer on JDK1.8, so apache#11594 use copy data to direct buffer to avoid NoSuchMethodError exception. Now aircompressor released 0.20 and apache#11790 has upgrade the aircompressor version to 0.20 to fix this issue, we can revert apache#11594 to avoid copy data to direct buffer to improve performance.

### Modification
1. revert Fix java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer when enabling topic metadata compression apache#11594, but keep the tests.
Jason918 pushed a commit that referenced this pull request Jul 28, 2022
Fix #11789

upgrade aircompressor from 0.19 to 0.20

(cherry picked from commit 051f52d)
@Jason918 Jason918 added cherry-picked/branch-2.7 Archived: 2.7 is end of life release/2.7.5 and removed release/2.7.6 labels Jul 28, 2022
Jason918 added a commit to Jason918/pulsar that referenced this pull request Jul 29, 2022
Jason918 pushed a commit to Jason918/pulsar that referenced this pull request Jul 30, 2022
Jason918 added a commit that referenced this pull request Jul 31, 2022
* Revert "[fix][proxy] Fix client service url (#16834)"

This reverts commit 10b4e99.

* Revert "[Build] Use grpc-bom to align grpc library versions (#15234)"

This reverts commit 99c93d2.

* Revert "upgrade aircompressor to 0.20 (#11790)"

This reverts commit 5ad16b6.

* Revert "[Branch-2.7] Fixed deadlock on metadata cache missing while doing checkReplication (#12484)"

This reverts commit 32fe228.

* Revert changes of PersistentTopic#getMessageTTL in #12339.

Co-authored-by: JiangHaiting <janghaiting@apache.org>
@Jason918 Jason918 removed the cherry-picked/branch-2.7 Archived: 2.7 is end of life label Jul 31, 2022
@github-actions
Copy link

@hangc0276 Please provide a correct documentation label for your PR.
Instructions see Pulsar Documentation Label Guide.

@Jason918
Copy link
Contributor

Jason918 commented Aug 1, 2022

Move release/2.7.5 label to #16893

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

java.lang.NoSuchMethodError: java.nio.ByteBuffer.position(I)Ljava/nio/ByteBuffer
6 participants