New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[package management service] fix wrappedBuffer
always using the same block of memory
#11782
[package management service] fix wrappedBuffer
always using the same block of memory
#11782
Conversation
wrappedBuffer
always having the same block of memory wrappedBuffer
always using the same block of memory
...e/src/main/java/org/apache/pulsar/packages/management/storage/bookkeeper/DLOutputStream.java
Outdated
Show resolved
Hide resolved
Good catch @freeznet ! I also added "release/2.7.4" since this looks like an important fix. |
or does it only apply to 2.8.x + ? I see that the change was made to DLOutputStream, but I guess that's not used asynchronously by Pulsar Functions upload, so that wouldn't be impacted? |
@lhotari thanks for asking. from my understanding this fix only applies to package management service, and not with Pulsar Functions upload, so it might not affect release 2.7.x |
…e block of memory (apache#11782)
Fixes #11781
Motivation
When uploading file content to bk, the
BookKeeperPackagesStorage
always use the same block of memory to read the file content and build up a bunch of zero-copyByteBuf
.This causes the
ByteBuf
s having the same block of memory and break the file content.Modifications
Alloc new memory block in each iteration.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Does this pull request potentially affect one of the following parts:
If
yes
was chosen, please highlight the changesDocumentation
For contributor
For this PR, do we need to update docs?
If yes, please update docs or create a follow-up issue if you need help.
If no, please explain why.
For committer
For this PR, do we need to update docs?
If yes,
if you update docs in this PR, label this PR with the
doc
label.if you plan to update docs later, label this PR with the
doc-required
label.if you need help on updating docs, create a follow-up issue with the
doc-required
label.If no, label this PR with the
no-need-doc
label and explain why.internal bug fix