Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix getPreviousPosition npe #11621

Merged
merged 4 commits into from Aug 11, 2021
Merged

fix getPreviousPosition npe #11621

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1854226
fix getPreviousPosition npe
Aug 10, 2021
d2722eb
make a copy of ledgers
Aug 10, 2021
dd10a62
change ledgersCopied to non concurrent map
Aug 10, 2021
ede0423
add null checker for copying ledgers too expensive
gaozhangmin Aug 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
View file
Open in desktop
Expand Up @@ -48,6 +48,7 @@
import java.util.Queue;
import java.util.Random;
import java.util.Set;
import java.util.TreeMap;
import java.util.UUID;
import java.util.concurrent.CompletableFuture;
import java.util.concurrent.CompletionException;
Expand Down Expand Up @@ -3205,21 +3206,22 @@ public PositionImpl getPreviousPosition(PositionImpl position) {
// The previous position will be the last position of an earlier ledgers
NavigableMap<Long, LedgerInfo> headMap = ledgers.headMap(position.getLedgerId(), false);

if (headMap.isEmpty()) {
final Map.Entry<Long, LedgerInfo> firstEntry = headMap.firstEntry();
if (firstEntry == null) {
// There is no previous ledger, return an invalid position in the current ledger
return PositionImpl.get(position.getLedgerId(), -1);
}

// We need to find the most recent non-empty ledger
for (long ledgerId : headMap.descendingKeySet()) {
LedgerInfo li = headMap.get(ledgerId);
if (li.getEntries() > 0) {
if (li != null && li.getEntries() > 0) {
return PositionImpl.get(li.getLedgerId(), li.getEntries() - 1);
}
}

// in case there are only empty ledgers, we return a position in the first one
return PositionImpl.get(headMap.firstEntry().getKey(), -1);
return PositionImpl.get(firstEntry.getKey(), -1);
}

/**
Expand Down