[Broker] Remove RateLimiter constructors and replace with builder usage #11599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhotari
added
area/broker
type/cleanup
merlimat
approved these changes
Aug 9, 2021
michaeljmarshall
pushed a commit
that referenced
this pull request
Dec 11, 2021
(cherry picked from commit fcd3336)
michaeljmarshall
added
cherry-picked/branch-2.7
|
Cherry picked to |
bharanic-dev
pushed a commit
to bharanic-dev/pulsar
that referenced
this pull request
Mar 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
RateLimiter class has multiple constructors. A Lombok builder was added as part of PR #10384 since there was a need to have yet another constructor. Having a lot of different constructors on a class is prone to errors and makes the code hard to read.
Modifications
This PR removes all public constructors from RateLimiter class and replaces the usages of constructors with the usage of the builder in existing code.